[GitHub] [hudi] danny0405 commented on a diff in pull request #8830: [MINOR] auto generate init client id

["danny0405 (via GitHub)" <gi...@apache.org>]

danny0405 commented on code in PR #8830:
URL: https://github.com/apache/hudi/pull/8830#discussion_r1208240329


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/ClientIds.java:
##########
@@ -69,7 +70,7 @@ public class ClientIds implements AutoCloseable, Serializable {
 
   private static final String HEARTBEAT_FOLDER_NAME = ".ids";
   private static final String HEARTBEAT_FILE_NAME_PREFIX = "_";
-  public static final String INIT_CLIENT_ID = "";
+  public static final String INIT_CLIENT_ID = String.valueOf(RandomUtils.nextInt(0,100));
   public static final long DEFAULT_HEARTBEAT_INTERVAL_IN_MS = 60 * 1000; // default 1 minute

Review Comment:
   Can we use Java util `Random` instead commons lang3, the apache commons is likely to conflict.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org