Where to submit patch to SQLExec.java

[Hunter Peress <hu...@gmail.com>]

I have two main accomplishments in this patch:

The first returns a row count in an efficient manner.

The second is specific to mysql, it processes the mysql delimter command and
is actually in its own file
named MySQLExec.java

How do I submit these?

Re: Where to submit patch to SQLExec.java

[Steve Loughran <st...@apache.org>]

Kevin Jackson wrote:
> If I recall, there was a previous discussion about whether SQLExec
> should/shouldn't be refactored to deal with the myriad backend dbs
> that it must support.  I don't think the discussion went anywhere in
> the end, but this task does have a lot of bug reps/enhancements filed
> against it
> 
> Kev
> 

Let's make this something for the 1.7.1 timeframe :)

As I mentioned on ant-user last week, I pulled a bit of the SqlExec task 
out for use in smartfrog, stripping it down quite a lot. There were some 
things there that I felt wouldnt work, like the delimiter checking if 
keepformatting=true, as a space at the end of the line would break the 
logic:

Bad :"DROP TABLE foo; "
Good: "DROP TABLE foo"

One big problem with sqlexec is the many databases out there, some of 
which cost $100K+, ignoring the hardware you need too. But that should 
not stop us testing on hssql, derby and possibly mysql, postgres all of 
which cost $0. Getting the test system up and running would be the first 
part of the problem.

-steve


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org

Re: Where to submit patch to SQLExec.java

[Kevin Jackson <fo...@gmail.com>]

If I recall, there was a previous discussion about whether SQLExec
should/shouldn't be refactored to deal with the myriad backend dbs
that it must support.  I don't think the discussion went anywhere in
the end, but this task does have a lot of bug reps/enhancements filed
against it

Kev

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org

Re: Where to submit patch to SQLExec.java

[Antoine Levy-Lambert <an...@gmx.de>]

Hello Hunter,

the usual procedure is to create a bug report under http://issues.apache.org/bugzilla and attach your patches to the bug report.

It would be cool if someone in the ant community would review the bug reports concerning SQLExec.

We committers are afraid of submitting some of these bug reports because we do not have access to the specific database backends covered by some of these bug reports. And because we would need a lot of testcases to guarantee the backward compatibility and good behavior of the modified code.

Regards,

Antoine



-------- Original-Nachricht --------
Datum: Mon, 30 Oct 2006 14:43:25 -0700
Von: "Hunter Peress" <hu...@gmail.com>
An: dev@ant.apache.org
Betreff: Where to submit patch to SQLExec.java

> I have two main accomplishments in this patch:
> 
> The first returns a row count in an efficient manner.
> 
> The second is specific to mysql, it processes the mysql delimter command
> and
> is actually in its own file
> named MySQLExec.java
> 
> How do I submit these?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org