You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by vargup <gi...@git.apache.org> on 2018/04/17 20:41:01 UTC
[GitHub] mesos pull request #283: Ignore acknowledge for task status update, received...
GitHub user vargup opened a pull request:
https://github.com/apache/mesos/pull/283
Ignore acknowledge for task status update, received out of order.
Ignore acknowledge for task status update, received out of order.
WIP: Integration test.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vargup/mesos ignore-outoforder-statusupdate-ack
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/mesos/pull/283.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #283
----
commit d74550cce5ae4dfd23b59efad7b5baa498d4eb49
Author: Varun Gupta <va...@...>
Date: 2018-04-17T20:39:34Z
Ignore task status update acknowledge received out of order.
----
---
[GitHub] mesos issue #283: Ignore acknowledge for task status update, received out of...
Posted by bmahler <gi...@git.apache.org>.
Github user bmahler commented on the issue:
https://github.com/apache/mesos/pull/283
Can you include a precise description of the bug?
---
[GitHub] mesos pull request #283: Ignore acknowledge for task status update, received...
Posted by zhitaoli <gi...@git.apache.org>.
Github user zhitaoli commented on a diff in the pull request:
https://github.com/apache/mesos/pull/283#discussion_r182226462
--- Diff: src/slave/task_status_update_manager.cpp ---
@@ -881,11 +881,21 @@ void TaskStatusUpdateStream::_handle(
// Add it to the pending updates queue.
pending.push(update);
} else {
- // Record this ACK.
- acknowledged.insert(id::UUID::fromBytes(update.uuid()).get());
+ StatusUpdate& pendingUpdate = pending.front();
--- End diff --
Make this const &
---
[GitHub] mesos pull request #283: Ignore acknowledge for task status update, received...
Posted by zhitaoli <gi...@git.apache.org>.
Github user zhitaoli commented on a diff in the pull request:
https://github.com/apache/mesos/pull/283#discussion_r182227665
--- Diff: src/slave/task_status_update_manager.cpp ---
@@ -881,11 +881,21 @@ void TaskStatusUpdateStream::_handle(
// Add it to the pending updates queue.
pending.push(update);
} else {
- // Record this ACK.
- acknowledged.insert(id::UUID::fromBytes(update.uuid()).get());
+ StatusUpdate& pendingUpdate = pending.front();
- // Remove the corresponding update from the pending queue.
- pending.pop();
+ if (pendingUpdate.uuid() == update.uuid()) {
--- End diff --
Can we use the _operator==()_ on the _id::UUID_ to compare the two fields instead?
---