You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudberry.apache.org by ji...@apache.org on 2025/01/16 13:16:05 UTC
(cloudberry) 22/35: Fix unused variable compile warnings
This is an automated email from the ASF dual-hosted git repository.
jiaqizho pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudberry.git
commit 4b3e0bb982fe66b3920b5f561eaf97686780fec3
Author: Chris Hajas <ch...@vmware.com>
AuthorDate: Thu Feb 9 10:15:30 2023 -0800
Fix unused variable compile warnings
---
src/backend/gpopt/relcache/CMDProviderRelcache.cpp | 5 -----
src/backend/gpopt/translate/CTranslatorDXLToPlStmt.cpp | 6 +++---
src/backend/gpopt/utils/COptTasks.cpp | 2 +-
.../gporca/libgpopt/src/translate/CTranslatorExprToDXL.cpp | 8 ++++----
src/include/gpopt/relcache/CMDProviderRelcache.h | 6 +-----
5 files changed, 9 insertions(+), 18 deletions(-)
diff --git a/src/backend/gpopt/relcache/CMDProviderRelcache.cpp b/src/backend/gpopt/relcache/CMDProviderRelcache.cpp
index ef187092bf..5c27f886ba 100644
--- a/src/backend/gpopt/relcache/CMDProviderRelcache.cpp
+++ b/src/backend/gpopt/relcache/CMDProviderRelcache.cpp
@@ -27,11 +27,6 @@ using namespace gpos;
using namespace gpdxl;
using namespace gpmd;
-CMDProviderRelcache::CMDProviderRelcache(CMemoryPool *mp) : m_mp(mp)
-{
- GPOS_ASSERT(nullptr != m_mp);
-}
-
CWStringBase *
CMDProviderRelcache::GetMDObjDXLStr(CMemoryPool *mp, CMDAccessor *md_accessor,
IMDId *md_id) const
diff --git a/src/backend/gpopt/translate/CTranslatorDXLToPlStmt.cpp b/src/backend/gpopt/translate/CTranslatorDXLToPlStmt.cpp
index e8ea26de50..539a02bf18 100644
--- a/src/backend/gpopt/translate/CTranslatorDXLToPlStmt.cpp
+++ b/src/backend/gpopt/translate/CTranslatorDXLToPlStmt.cpp
@@ -3117,9 +3117,9 @@ CTranslatorDXLToPlStmt::TranslateDXLSort(
CDXLTranslationContextArray *ctxt_translation_prev_siblings)
{
// Ensure operator of sort_dxlnode exists and is EdxlopPhysicalSort
- CDXLOperator *sort_dxlop = sort_dxlnode->GetOperator();
- GPOS_ASSERT(nullptr != sort_dxlop);
- GPOS_ASSERT(EdxlopPhysicalSort == sort_dxlop->GetDXLOperator());
+ GPOS_ASSERT(nullptr != sort_dxlnode->GetOperator());
+ GPOS_ASSERT(EdxlopPhysicalSort ==
+ sort_dxlnode->GetOperator()->GetDXLOperator());
// create sort plan node
Sort *sort = MakeNode(Sort);
diff --git a/src/backend/gpopt/utils/COptTasks.cpp b/src/backend/gpopt/utils/COptTasks.cpp
index 9d3e8e9e6c..a0a7a95efc 100644
--- a/src/backend/gpopt/utils/COptTasks.cpp
+++ b/src/backend/gpopt/utils/COptTasks.cpp
@@ -526,7 +526,7 @@ COptTasks::OptimizeTask(void *ptr)
// set up relcache MD provider
CMDProviderRelcache *relcache_provider =
- GPOS_NEW(mp) CMDProviderRelcache(mp);
+ GPOS_NEW(mp) CMDProviderRelcache();
{
// scope for MD accessor
diff --git a/src/backend/gporca/libgpopt/src/translate/CTranslatorExprToDXL.cpp b/src/backend/gporca/libgpopt/src/translate/CTranslatorExprToDXL.cpp
index d1edb4bb22..c129b04b26 100644
--- a/src/backend/gporca/libgpopt/src/translate/CTranslatorExprToDXL.cpp
+++ b/src/backend/gporca/libgpopt/src/translate/CTranslatorExprToDXL.cpp
@@ -1358,7 +1358,7 @@ CTranslatorExprToDXL::PdxlnDynamicTableScan(
{
const CBitSet *bs = pps_reqd->SelectorIds(popDTS->ScanId());
CBitSetIter bsi(*bs);
- for (ULONG ul = 0; bsi.Advance(); ul++)
+ while (bsi.Advance())
{
selector_ids->Append(GPOS_NEW(m_mp) ULONG(bsi.Bit()));
}
@@ -1458,7 +1458,7 @@ CTranslatorExprToDXL::PdxlnDynamicBitmapTableScan(
{
const CBitSet *bs = pps_reqd->SelectorIds(pop->ScanId());
CBitSetIter bsi(*bs);
- for (ULONG ul = 0; bsi.Advance(); ul++)
+ while (bsi.Advance())
{
selector_ids->Append(GPOS_NEW(m_mp) ULONG(bsi.Bit()));
}
@@ -1561,7 +1561,7 @@ CTranslatorExprToDXL::PdxlnDynamicIndexScan(
{
const CBitSet *bs = pps_reqd->SelectorIds(popDIS->ScanId());
CBitSetIter bsi(*bs);
- for (ULONG ul = 0; bsi.Advance(); ul++)
+ while (bsi.Advance())
{
selector_ids->Append(GPOS_NEW(m_mp) ULONG(bsi.Bit()));
}
@@ -4824,7 +4824,7 @@ CTranslatorExprToDXL::PdxlnPartitionSelector(
GPOS_ASSERT(nullptr != bs);
ULongPtrArray *parts = GPOS_NEW(m_mp) ULongPtrArray(m_mp);
CBitSetIter bsi(*bs);
- for (ULONG ul = 0; bsi.Advance(); ul++)
+ while (bsi.Advance())
{
parts->Append(GPOS_NEW(m_mp) ULONG(bsi.Bit()));
}
diff --git a/src/include/gpopt/relcache/CMDProviderRelcache.h b/src/include/gpopt/relcache/CMDProviderRelcache.h
index 97776e9e4d..1825856205 100644
--- a/src/include/gpopt/relcache/CMDProviderRelcache.h
+++ b/src/include/gpopt/relcache/CMDProviderRelcache.h
@@ -45,15 +45,11 @@ using namespace gpos;
//---------------------------------------------------------------------------
class CMDProviderRelcache : public IMDProvider
{
-private:
- // memory pool
- CMemoryPool *m_mp;
-
public:
CMDProviderRelcache(const CMDProviderRelcache &) = delete;
// ctor/dtor
- explicit CMDProviderRelcache(CMemoryPool *mp);
+ CMDProviderRelcache() = default;
~CMDProviderRelcache() override = default;
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org