[GitHub] [flink] masteryhx commented on pull request #22439: [FLINK-31875][filesystems] Override the flink-parent dependencyManagement definition for hadoop-common of OSS

["masteryhx (via GitHub)" <gi...@apache.org>]

masteryhx commented on PR #22439:
URL: https://github.com/apache/flink/pull/22439#issuecomment-1521277618

   > @masteryhx Can you add tests? I believe that's actually missing in this entire setup, now we don't work if this code works or not.
   
   Thanks for the review.
   IIUC, The exception could be reproduced by some tests like HadoopOSSFileSystemITCase if OSS credentials are configured.
   Maybe I missed something, Do we need to add or change the test?
   
   About whetehr it's necessary, 
   I think we may need to guarantee that it could run normally even if users don't configure anything. And make all tests pass.
   Of course, users could configure their own dependency to overide.
   
   I think it's best to ensure ${fs.hadoopshaded.version} is used for this file system just like S3 has done (see https://github.com/apache/flink/blob/master/flink-filesystems/flink-s3-fs-hadoop/pom.xml#L34).
   WDYT?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org