Re: [PR] IGNITE-27560 Move BinaryObjectImpl to binary-impl [ignite]

["zstan (via GitHub)" <gi...@apache.org>]

zstan commented on code in PR #12633:
URL: https://github.com/apache/ignite/pull/12633#discussion_r2690511698


##########
modules/binary/api/src/main/java/org/apache/ignite/internal/binary/BinariesFactory.java:
##########
@@ -143,4 +150,22 @@ public BinaryReaderEx reader(BinaryContext ctx,
      * @return Map of function returning size of the object.
      */
     public Map<Class<?>, ToIntFunction<Object>> sizeProviders();
+
+    /**
+     * Compare two objects for DML operation.
+     *
+     * @param first First.
+     * @param second Second.
+     * @return Comparison result.
+     */
+    public int compareForDml(Object first, Object second);

Review Comment:
   let`s fix compare contract ? If First (need to be renamed to - 'First parameter' or smth like this) is greather than Second - what result will return in such a case ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org