You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2024/03/06 20:30:00 UTC
[jira] [Work logged] (ARTEMIS-4664) autoCreatedResource can get removed while receiving batch of messages
[ https://issues.apache.org/jira/browse/ARTEMIS-4664?focusedWorklogId=908622&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-908622 ]
ASF GitHub Bot logged work on ARTEMIS-4664:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Mar/24 20:29
Start Date: 06/Mar/24 20:29
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4836:
URL: https://github.com/apache/activemq-artemis/pull/4836#discussion_r1515116973
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java:
##########
@@ -3919,7 +3919,10 @@ private void createResources(boolean isAutoCreate, SimpleString destinationAddre
SimpleString destinationQueueName = prefix.concat(getAddress()).concat(suffix);
SimpleString filter = new SimpleString(String.format("%s = '%s'", Message.HDR_ORIGINAL_ADDRESS, getAddress()));
try {
- server.createQueue(new QueueConfiguration(destinationQueueName).setAddress(destinationAddress).setFilterString(filter).setAutoCreated(true).setAutoCreateAddress(true), true);
+ Queue destinationQueue = server.createQueue(new QueueConfiguration(destinationQueueName).setAddress(destinationAddress).setFilterString(filter).setAutoCreated(true).setAutoCreateAddress(true), true);
+ if (destinationQueue != null && destinationQueue.isSwept()) {
+ destinationQueue.setSwept(false);
Review Comment:
shouldn't this be done here instead?
https://github.com/apache/activemq-artemis/blob/5ce70f9e37ba1bb7c56372c2e79f9e9d8c9d1fa5/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java#L4093
Issue Time Tracking
-------------------
Worklog Id: (was: 908622)
Time Spent: 20m (was: 10m)
> autoCreatedResource can get removed while receiving batch of messages
> ---------------------------------------------------------------------
>
> Key: ARTEMIS-4664
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4664
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Anton Roskvist
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> There is a very small window where an auto created resource can get auto-removed while receiving a batch of new messages.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)