You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by wu...@apache.org on 2025/01/04 13:07:26 UTC
(skywalking) branch fix-measure-field created (now 5ad4ce8956)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch fix-measure-field
in repository https://gitbox.apache.org/repos/asf/skywalking.git
at 5ad4ce8956 Fix `AvgHistogramPercentileFunction` doesn't have proper field definition for `ranks`.
This branch includes the following new commits:
new 5ad4ce8956 Fix `AvgHistogramPercentileFunction` doesn't have proper field definition for `ranks`.
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
(skywalking) 01/01: Fix `AvgHistogramPercentileFunction` doesn't have proper field definition for `ranks`.
Posted by wu...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch fix-measure-field
in repository https://gitbox.apache.org/repos/asf/skywalking.git
commit 5ad4ce89565183bcc6672ffa6945fc2af5f6cc1a
Author: Wu Sheng <wu...@foxmail.com>
AuthorDate: Sat Jan 4 21:07:16 2025 +0800
Fix `AvgHistogramPercentileFunction` doesn't have proper field definition for `ranks`.
---
docs/en/changes/changes.md | 1 +
.../analysis/meter/function/avg/AvgHistogramPercentileFunction.java | 1 +
.../skywalking/oap/server/core/storage/annotation/BanyanDB.java | 4 ++++
3 files changed, 6 insertions(+)
diff --git a/docs/en/changes/changes.md b/docs/en/changes/changes.md
index 8d1f9bba8a..47bf0f301c 100644
--- a/docs/en/changes/changes.md
+++ b/docs/en/changes/changes.md
@@ -51,6 +51,7 @@
* Fix missing remote endpoint IP address in span query of zipkin query module.
* Fix `hierarchy-definition.yml` config file packaged into start.jar wrongly.
* Add `bydb.dependencies.properties` config file to define server dependency versions.
+* Fix `AvgHistogramPercentileFunction` doesn't have proper field definition for `ranks`.
#### UI
diff --git a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/meter/function/avg/AvgHistogramPercentileFunction.java b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/meter/function/avg/AvgHistogramPercentileFunction.java
index b64be88d67..7716febfe1 100644
--- a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/meter/function/avg/AvgHistogramPercentileFunction.java
+++ b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/meter/function/avg/AvgHistogramPercentileFunction.java
@@ -109,6 +109,7 @@ public abstract class AvgHistogramPercentileFunction extends Meter implements Ac
@Getter
@Setter
@Column(name = RANKS, storageOnly = true)
+ @BanyanDB.MeasureField
private IntList ranks = new IntList(10);
private boolean isCalculated = false;
diff --git a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/annotation/BanyanDB.java b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/annotation/BanyanDB.java
index af31fab4b1..9df877c9e8 100644
--- a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/annotation/BanyanDB.java
+++ b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/annotation/BanyanDB.java
@@ -124,6 +124,8 @@ public @interface BanyanDB {
/**
* MeasureField defines a column as a measure's field.
+ * The measure field has a significant difference from no-indexing tag.
+ * The measure fields are stored in another file, but no-indexing tag is stored in the same file with the indexing tags.
* <p>
* Annotated: the column is a measure field.
* Unannotated: the column is a measure tag.
@@ -219,6 +221,8 @@ public @interface BanyanDB {
/**
* IndexMode is used to indicate the index mode of the metric.
* All columns in the metric will be stored in the index exclusively.
+ * When a field is not used in query condition, only {@link Column#storageOnly()} is allowed.
+ * No {@link MeasureField} is allowed in IndexMode entity,
*
* @since 10.2.0
*/