You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tez.apache.org by go...@apache.org on 2018/07/13 05:39:25 UTC

tez git commit: TEZ-3965: TestMROutput: Fix the hard-coded /tmp/output paths (Jaume Marhuenda, reviewed by Gopal V)

Repository: tez
Updated Branches:
  refs/heads/master 957e34f81 -> 7e397b4f8


TEZ-3965: TestMROutput: Fix the hard-coded /tmp/output paths (Jaume Marhuenda, reviewed by Gopal V)

Signed-off-by: Gopal V <go...@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/tez/repo
Commit: http://git-wip-us.apache.org/repos/asf/tez/commit/7e397b4f
Tree: http://git-wip-us.apache.org/repos/asf/tez/tree/7e397b4f
Diff: http://git-wip-us.apache.org/repos/asf/tez/diff/7e397b4f

Branch: refs/heads/master
Commit: 7e397b4f8ebc5f8faec3e6fc4fd634c9d02cb3e4
Parents: 957e34f
Author: Jaume Marhuenda <jm...@hortonworks.com>
Authored: Thu Jul 12 22:39:09 2018 -0700
Committer: Gopal V <go...@apache.org>
Committed: Thu Jul 12 22:39:09 2018 -0700

----------------------------------------------------------------------
 .../tez/mapreduce/output/TestMROutput.java      | 36 +++++++++++++-------
 1 file changed, 24 insertions(+), 12 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tez/blob/7e397b4f/tez-mapreduce/src/test/java/org/apache/tez/mapreduce/output/TestMROutput.java
----------------------------------------------------------------------
diff --git a/tez-mapreduce/src/test/java/org/apache/tez/mapreduce/output/TestMROutput.java b/tez-mapreduce/src/test/java/org/apache/tez/mapreduce/output/TestMROutput.java
index f3403e6..c60ca22 100644
--- a/tez-mapreduce/src/test/java/org/apache/tez/mapreduce/output/TestMROutput.java
+++ b/tez-mapreduce/src/test/java/org/apache/tez/mapreduce/output/TestMROutput.java
@@ -28,6 +28,7 @@ import java.io.Writer;
 import java.util.HashMap;
 import java.util.List;
 
+import com.google.common.io.Files;
 import org.apache.hadoop.conf.Configuration;
 import org.apache.hadoop.fs.FileSystem;
 import org.apache.hadoop.fs.Path;
@@ -66,6 +67,7 @@ import org.apache.tez.runtime.api.impl.TaskSpec;
 import org.apache.tez.runtime.api.impl.TezUmbilical;
 import org.apache.tez.runtime.library.api.KeyValueWriter;
 import org.apache.tez.runtime.library.processor.SimpleProcessor;
+import org.junit.BeforeClass;
 import org.junit.Ignore;
 import org.junit.Test;
 
@@ -75,13 +77,21 @@ import com.google.common.collect.Lists;
 
 public class TestMROutput {
 
+  static File tmpDir;
+
+  @BeforeClass
+  public static void setupClass () {
+    tmpDir = Files.createTempDir();
+    tmpDir.deleteOnExit();
+  }
+
   @Test(timeout = 5000)
   public void testNewAPI_TextOutputFormat() throws Exception {
-    String outputPath = "/tmp/output";
     Configuration conf = new Configuration();
     conf.setBoolean(MRConfig.IS_MAP_PROCESSOR, true);
     DataSinkDescriptor dataSink = MROutput
-        .createConfigBuilder(conf, TextOutputFormat.class, outputPath)
+        .createConfigBuilder(conf, TextOutputFormat.class,
+            tmpDir.getPath())
         .build();
 
     OutputContext outputContext = createMockOutputContext(dataSink.getOutputDescriptor().getUserPayload());
@@ -101,11 +111,12 @@ public class TestMROutput {
 
   @Test(timeout = 5000)
   public void testOldAPI_TextOutputFormat() throws Exception {
-    String outputPath = "/tmp/output";
     Configuration conf = new Configuration();
     conf.setBoolean(MRConfig.IS_MAP_PROCESSOR, false);
     DataSinkDescriptor dataSink = MROutput
-        .createConfigBuilder(conf, org.apache.hadoop.mapred.TextOutputFormat.class, outputPath)
+        .createConfigBuilder(conf,
+            org.apache.hadoop.mapred.TextOutputFormat.class,
+            tmpDir.getPath())
         .build();
 
     OutputContext outputContext = createMockOutputContext(dataSink.getOutputDescriptor().getUserPayload());
@@ -125,12 +136,12 @@ public class TestMROutput {
 
   @Test(timeout = 5000)
   public void testNewAPI_SequenceFileOutputFormat() throws Exception {
-    String outputPath = "/tmp/output";
     JobConf conf = new JobConf();
     conf.setOutputKeyClass(NullWritable.class);
     conf.setOutputValueClass(Text.class);
     DataSinkDescriptor dataSink = MROutput
-        .createConfigBuilder(conf, SequenceFileOutputFormat.class, outputPath)
+        .createConfigBuilder(conf, SequenceFileOutputFormat.class,
+            tmpDir.getPath())
         .build();
 
     OutputContext outputContext = createMockOutputContext(dataSink.getOutputDescriptor().getUserPayload());
@@ -149,12 +160,13 @@ public class TestMROutput {
 
   @Test(timeout = 5000)
   public void testOldAPI_SequenceFileOutputFormat() throws Exception {
-    String outputPath = "/tmp/output";
     JobConf conf = new JobConf();
     conf.setOutputKeyClass(NullWritable.class);
     conf.setOutputValueClass(Text.class);
     DataSinkDescriptor dataSink = MROutput
-        .createConfigBuilder(conf, org.apache.hadoop.mapred.SequenceFileOutputFormat.class, outputPath)
+        .createConfigBuilder(conf,
+            org.apache.hadoop.mapred.SequenceFileOutputFormat.class,
+            tmpDir.getPath())
         .build();
 
     OutputContext outputContext = createMockOutputContext(dataSink.getOutputDescriptor().getUserPayload());
@@ -175,11 +187,11 @@ public class TestMROutput {
   // set while creating recordWriters
   @Test(timeout = 5000)
   public void testNewAPI_WorkOutputPathOutputFormat() throws Exception {
-    String outputPath = "/tmp/output";
     Configuration conf = new Configuration();
     conf.setBoolean(MRConfig.IS_MAP_PROCESSOR, true);
     DataSinkDescriptor dataSink = MROutput
-      .createConfigBuilder(conf, NewAPI_WorkOutputPathReadingOutputFormat.class, outputPath)
+      .createConfigBuilder(conf, NewAPI_WorkOutputPathReadingOutputFormat.class,
+          tmpDir.getPath())
       .build();
 
     OutputContext outputContext = createMockOutputContext(dataSink.getOutputDescriptor().getUserPayload());
@@ -201,11 +213,11 @@ public class TestMROutput {
   // set while creating recordWriters
   @Test(timeout = 5000)
   public void testOldAPI_WorkOutputPathOutputFormat() throws Exception {
-    String outputPath = "/tmp/output";
     Configuration conf = new Configuration();
     conf.setBoolean(MRConfig.IS_MAP_PROCESSOR, false);
     DataSinkDescriptor dataSink = MROutput
-      .createConfigBuilder(conf, OldAPI_WorkOutputPathReadingOutputFormat.class, outputPath)
+      .createConfigBuilder(conf, OldAPI_WorkOutputPathReadingOutputFormat.class,
+          tmpDir.getPath())
       .build();
 
     OutputContext outputContext = createMockOutputContext(dataSink.getOutputDescriptor().getUserPayload());