Re: [PR] feat: 完善 RocketMQ 订阅关系、消费位点、ACL 及管理接口 [eventmesh-dashboard]

["Copilot (via GitHub)" <gi...@apache.org>]

Copilot commented on code in PR #230:
URL: https://github.com/apache/eventmesh-dashboard/pull/230#discussion_r4059131131


##########
eventmesh-dashboard-core/pom.xml:
##########
@@ -164,6 +164,58 @@
                 </plugins>
             </build>
         </profile>
+        <profile>
+            <id>rocketmq-offset-tests</id>
+            <build>
+                <plugins>
+                    <plugin>
+                        <groupId>org.apache.maven.plugins</groupId>
+                        <artifactId>maven-compiler-plugin</artifactId>
+                        <configuration>
+                            <testIncludes combine.self="override">
+                                <testInclude>**/RocketMQOffset*Test.java</testInclude>
+                            </testIncludes>

Review Comment:
   These profiles do not isolate the new live-Broker integration tests from the normal test lifecycle. The parent Surefire configuration includes `**/*Test*.java` with no exclusions, so every new `*IntegrationTest.java` is still compiled and executed by the CI `mvn test` command even when no RocketMQ broker is available; failures are also hidden by the parent's `testFailureIgnore=true`. Rename/use Failsafe for integration tests, or exclude them by default and include them only in an explicit broker-backed profile.



##########
eventmesh-dashboard-core/src/main/java/org/apache/eventmesh/dashboard/core/function/SDK/config/CreateRemotingConfig.java:
##########
@@ -18,6 +18,17 @@
 
 package org.apache.eventmesh.dashboard.core.function.SDK.config;
 
+import lombok.Getter;
+import lombok.Setter;
+
+@Getter
+@Setter
 public class CreateRemotingConfig extends AbstractSimpleCreateSDKConfig {
 
+    private AclVersion aclVersion = AclVersion.V2;

Review Comment:
   The ACL version is never populated by the production registration path, so this defaults every managed RocketMQ runtime to V2 and makes the advertised V1 selection unavailable outside tests. `ClusterMetadataDomain#createRuntimeDO` creates this config and only sets `key` and `netAddress`, and the only `setAclVersion` calls in the repository are test code. Please wire an ACL-version setting from runtime configuration into `CreateRemotingConfig` before registering the ADMIN client.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org