You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/15 19:11:43 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35856: [SPARK-38550][SQL][CORE] Use a disk-based store to save more debug information for live UI
dongjoon-hyun commented on a change in pull request #35856:
URL: https://github.com/apache/spark/pull/35856#discussion_r827327094
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Status.scala
##########
@@ -70,4 +70,11 @@ private[spark] object Status {
.version("3.0.0")
.booleanConf
.createWithDefault(false)
+
+ val DISK_STORE_DIR_FOR_STATUS =
+ ConfigBuilder("spark.appStatusStore.diskStore.dir")
+ .doc("Local directory where to store app status that couldn't fit in memory")
Review comment:
We can use this even when app status fits in the memory, can't we?
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Status.scala
##########
@@ -70,4 +70,11 @@ private[spark] object Status {
.version("3.0.0")
.booleanConf
.createWithDefault(false)
+
+ val DISK_STORE_DIR_FOR_STATUS =
+ ConfigBuilder("spark.appStatusStore.diskStore.dir")
+ .doc("Local directory where to store app status that couldn't fit in memory")
Review comment:
We can use this even when app status fits in the memory, can't we?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org