[GitHub] [incubator-doris] morningman commented on a change in pull request #8235: [fix](planner) Convert format in RewriteFromUnixTimeRule

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #8235:
URL: https://github.com/apache/incubator-doris/pull/8235#discussion_r814045659



##########
File path: fe/fe-core/src/main/java/org/apache/doris/rewrite/RewriteFromUnixTimeRule.java
##########
@@ -17,6 +17,7 @@
 
 package org.apache.doris.rewrite;
 
+import com.google.common.collect.ImmutableSet;

Review comment:
       import order

##########
File path: fe/fe-core/src/main/java/org/apache/doris/rewrite/RewriteFromUnixTimeRule.java
##########
@@ -41,7 +44,22 @@
  * this rewrite can improve the query performance, because from_unixtime is cpu-exhausted
  * */
 public class RewriteFromUnixTimeRule implements ExprRewriteRule {
+
+    private static final Logger logger = LoggerFactory.getLogger(RewriteFromUnixTimeRule.class);

Review comment:
       Not used?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org