You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Bruno Aranda <br...@gmail.com> on 2006/02/22 20:36:11 UTC
Re: svn commit: r379759 - /myfaces/core/trunk/api/src/main/java/javax/faces/convert/DoubleConverter.java
We used the convertedId javax.faces.DoubleTime, due to an error in the
spec (or the javadoc) for JSF 1.1. In JSF 1.2 this has been fixed, but
I suggest to use the wrong converterId in 1.1 to pass the TCK and to
have the same behaviour than the RI...
Regards,
Bruno
On 2/22/06, imario@apache.org <im...@apache.org> wrote:
> Author: imario
> Date: Wed Feb 22 04:28:15 2006
> New Revision: 379759
>
> URL: http://svn.apache.org/viewcvs?rev=379759&view=rev
> Log:
> corrected converterID name
>
> Modified:
> myfaces/core/trunk/api/src/main/java/javax/faces/convert/DoubleConverter.java
>
> Modified: myfaces/core/trunk/api/src/main/java/javax/faces/convert/DoubleConverter.java
> URL: http://svn.apache.org/viewcvs/myfaces/core/trunk/api/src/main/java/javax/faces/convert/DoubleConverter.java?rev=379759&r1=379758&r2=379759&view=diff
> ==============================================================================
> --- myfaces/core/trunk/api/src/main/java/javax/faces/convert/DoubleConverter.java (original)
> +++ myfaces/core/trunk/api/src/main/java/javax/faces/convert/DoubleConverter.java Wed Feb 22 04:28:15 2006
> @@ -28,7 +28,7 @@
> implements Converter
> {
> // API FIELDS
> - public static final String CONVERTER_ID = "javax.faces.DoubleTime";
> + public static final String CONVERTER_ID = "javax.faces.Double";
>
>
> private static final String CONVERSION_MESSAGE_ID = "javax.faces.convert.DoubleConverter.CONVERSION";
>
>
>
Re: svn commit: r379759 - /myfaces/core/trunk/api/src/main/java/javax/faces/convert/DoubleConverter.java
Posted by Mario Ivankovits <ma...@ops.co.at>.
Hi!
> As far as I remember, we ran into some issue with the right field...
>
> Can you remove it (the right one) and add some javadoc on that.
> JSF 1.2 has been fixed. I think there is a Jira ticket on that...
>
Ok, I reverted my change - even if its really odd to have to do it ;-)
---
Mario
Re: svn commit: r379759 - /myfaces/core/trunk/api/src/main/java/javax/faces/convert/DoubleConverter.java
Posted by Matthias Wessendorf <mw...@gmail.com>.
As far as I remember, we ran into some issue with the right field...
Can you remove it (the right one) and add some javadoc on that.
JSF 1.2 has been fixed. I think there is a Jira ticket on that...
On 2/22/06, Mario Ivankovits <ma...@ops.co.at> wrote:
> Bruno Aranda schrieb:
> > We used the convertedId javax.faces.DoubleTime, due to an error in the
> > spec (or the javadoc) for JSF 1.1. In JSF 1.2 this has been fixed, but
> > I suggest to use the wrong converterId in 1.1 to pass the TCK and to
> > have the same behaviour than the RI...
> >
> Ups, sorry! I just thought it is a easy change as the field CONVERTER_ID
> will never be used.
> Do the TCK test directly check this field?
>
> ---
> Mario
>
>
--
Matthias Wessendorf
Zülpicher Wall 12, 239
50674 Köln
http://www.wessendorf.net
mwessendorf-at-gmail-dot-com
Re: svn commit: r379759 - /myfaces/core/trunk/api/src/main/java/javax/faces/convert/DoubleConverter.java
Posted by Mario Ivankovits <ma...@ops.co.at>.
Bruno Aranda schrieb:
> We used the convertedId javax.faces.DoubleTime, due to an error in the
> spec (or the javadoc) for JSF 1.1. In JSF 1.2 this has been fixed, but
> I suggest to use the wrong converterId in 1.1 to pass the TCK and to
> have the same behaviour than the RI...
>
Ups, sorry! I just thought it is a easy change as the field CONVERTER_ID
will never be used.
Do the TCK test directly check this field?
---
Mario