[GitHub] [superset] nisheldo commented on a diff in pull request #22623: chore: skip puppeteer chromium download

[GitBox <gi...@apache.org>]

nisheldo commented on code in PR #22623:
URL: https://github.com/apache/superset/pull/22623#discussion_r1064749906


##########
Dockerfile:
##########
@@ -23,6 +23,7 @@ FROM node:16-slim AS superset-node
 
 ARG NPM_BUILD_CMD="build"
 ENV BUILD_CMD=${NPM_BUILD_CMD}
+ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true

Review Comment:
   Puppeteer is a dependency of Apitools - that runs a cron in github actions
   
   Not actually needed in the docker image build - skipping the download in the dockerfile wont affect the apitools tests



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org