You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by twalthr <gi...@git.apache.org> on 2016/08/10 12:38:16 UTC
[GitHub] flink pull request #2348: [FLINK-4359] [table] Add INTERVAL type
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/2348
[FLINK-4359] [table] Add INTERVAL type
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
This PR introduces INTERVAL types for Table API/SQL. Here are some examples how intervals can be used in the APIs. More examples can be found in `TemporalTypesTest`.
```
testAllApis(
1.year,
"1.year",
"INTERVAL '1' YEAR",
"+1-00")
testAllApis(
'f0 + 2.day,
"f0 + 2.day",
"f0 + INTERVAL '2' DAY",
"1990-10-16")
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twalthr/flink FLINK-4359
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2348.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2348
----
commit 67540ed4f6da59c0853e1c56134166173329c1d9
Author: twalthr <tw...@apache.org>
Date: 2016-08-08T08:15:49Z
[FLINK-4359] [table] Add INTERVAL type
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2348: [FLINK-4359] [table] Add INTERVAL type
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2348
Ok, I figured as much. A bit ugly but I guess everyone has to do it like this. \U0001f605
From a quick glance the API and implementation look good. \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2348: [FLINK-4359] [table] Add INTERVAL type
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2348
@aljoscha would be great if you could have a quick look on it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2348: [FLINK-4359] [table] Add INTERVAL type
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2348
The first line is Scala Table API, second line is Java Table API and the string with the INTERVAL prefix is standard SQL. So we cannot change the standard ;)
Yes, I think that is the reason. Calcite does it like that and Oracle too.
https://docs.oracle.com/cd/B19306_01/server.102/b14200/sql_elements003.htm#i38598
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2348: [FLINK-4359] [table] Add INTERVAL type
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2348
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2348: [FLINK-4359] [table] Add INTERVAL type
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2348
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2348: [FLINK-4359] [table] Add INTERVAL type
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2348
Is the `INTERVAL` prefix needed to make it work with the parser? Otherwise it would be nice to just write `2 DAYS`, or something like that.
By the way, the reason for the two different interval types is that the millis type does not have enough range to represent years?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---