[jira] [Commented] (MESOS-361) Restrict the character space of user provided TaskIDs.

["Jameel Al-Aziz (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980576#comment-13980576 ] 

Jameel Al-Aziz commented on MESOS-361:
--------------------------------------

The patch seems to accept spaces as a valid character in the TaskID.

However, spaces seems to break 0.18 in at least two places:
1. The API calls to the slaves encode the spaces to "+" which the slaves seem to not decode properly and return 404s instead
2. Having a space in the task ID seems to break the default executor. (e.g. a task ID named "ChronosTask:Move Pixel Logs" results in a failed task with a stderr of "/usr/bin/env: Pixel: No such file or directory")

Would it be more appropriate to file those issues as bugs or simply further restrict the valid character set?

> Restrict the character space of user provided TaskIDs.
> ------------------------------------------------------
>
>                 Key: MESOS-361
>                 URL: https://issues.apache.org/jira/browse/MESOS-361
>             Project: Mesos
>          Issue Type: Bug
>            Reporter: Benjamin Mahler
>            Assignee: Dominic Hamon
>              Labels: newbie
>             Fix For: 0.19.0
>
>
> We need to restrict the character space of our identifiers.
>   -FrameworkID
>   -ExecutorID
>   -ExecutorInfo.source
>   -TaskID
> Using whitespace in these is messy, but using things like forward slashes will break functionality!
> In particular, file system operations using the ids, as well as statistics usage potentially.



--
This message was sent by Atlassian JIRA
(v6.2#6252)