You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Julian Hyde (Jira)" <ji...@apache.org> on 2022/10/20 20:16:00 UTC

[jira] [Resolved] (CALCITE-5338) In Avatica's DateTimeUtils, replace floorDiv and floorMod with equivalents in java.lang.Math

     [ https://issues.apache.org/jira/browse/CALCITE-5338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Hyde resolved CALCITE-5338.
----------------------------------
    Resolution: Fixed

Fixed in [Avatica e2ba4a7c|https://github.com/apache/calcite-avatica/commit/e2ba4a7c313dcfbfc002aac4f5e228a47954fa78] and [Calcite 27592e55|https://github.com/apache/calcite/commit/27592e55764a0c3ef394a3c6a7ac45e28ca69604].

> In Avatica's DateTimeUtils, replace floorDiv and floorMod with equivalents in java.lang.Math 
> ---------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-5338
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5338
>             Project: Calcite
>          Issue Type: Bug
>          Components: avatica, core
>            Reporter: Julian Hyde
>            Priority: Major
>             Fix For: avatica-1.23.0, 1.33.0
>
>
> In Avatica's {{DateTimeUtils}}, replace {{floorDiv}} and {{floorMod}} with equivalents in {{java.lang.Math}}.
> The JDK equivalents were introduced in Java 8 (after Avatica was written) but now possibly have superior performance (due to intrinsics).
> {{floorMod(long, int)}}, which was introduced in JDK 9, is still off-limits.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)