You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Josh Elser (JIRA)" <ji...@apache.org> on 2017/11/16 13:23:00 UTC

[jira] [Commented] (HBASE-19280) Move HFileWriterImpl.compressionByName(String name) to some utility class

    [ https://issues.apache.org/jira/browse/HBASE-19280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16255289#comment-16255289 ] 

Josh Elser commented on HBASE-19280:
------------------------------------

Thanks, Ankit!

We have this utility method for getting a compression algorithm hidden away on the implementation of HFile.Writer which is marked as private. Phoenix happened to be using this one. We should probably find a new home for it.

> Move HFileWriterImpl.compressionByName(String name) to some utility class
> -------------------------------------------------------------------------
>
>                 Key: HBASE-19280
>                 URL: https://issues.apache.org/jira/browse/HBASE-19280
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ankit Singhal
>            Priority: Trivial
>             Fix For: 2.0.0-beta-1
>
>
> This method can be moved to some utility (related jira PHOENIX-4368).
> {code}
> public static Compression.Algorithm compressionByName(String algoName) {
>     if (algoName == null)
>       return HFile.DEFAULT_COMPRESSION_ALGORITHM;
>     return Compression.getCompressionAlgorithmByName(algoName);
>   }
> {code}
> FYI, [~elserj]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)