You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/04/30 06:20:29 UTC
[GitHub] [incubator-superset] mistercrunch commented on issue #6827:
Separate vis-specific controls from centralized controls
mistercrunch commented on issue #6827: Separate vis-specific controls from centralized controls
URL: https://github.com/apache/incubator-superset/pull/6827#issuecomment-487832552
@kristw on my PR I'm mostly just touching/refactoring `store.js`, and I think most of your changes on that file here are around naming (except for `getControlItems` where you go a bit deeper...). I could add flow + flatMap on my side.
Maybe you can leave your changes out on that file so I can get my PR in? Otherwise it looks like it will conflict pretty hard.
My PR addresses some of the bad names and breaks down the big nasty functions into smaller chunks and introduces decent test coverage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org