[GitHub] [commons-collections] aherbert commented on a diff in pull request #396: make EnhancedDoubleHasher.mod() public

["aherbert (via GitHub)" <gi...@apache.org>]

aherbert commented on code in PR #396:
URL: https://github.com/apache/commons-collections/pull/396#discussion_r1228003621


##########
src/test/java/org/apache/commons/collections4/bloomfilter/EnhancedDoubleHasherTest.java:
##########
@@ -99,7 +99,7 @@ void testModEdgeCases() {
         for (final long dividend : new long[] {-1, -2, -3, -6378683, -23567468136887892L, Long.MIN_VALUE, 345, 678686,
             67868768686878924L, Long.MAX_VALUE}) {
             for (final int divisor : new int[] {1, 2, 3, 5, 13, Integer.MAX_VALUE}) {
-                assertEquals((int) Long.remainderUnsigned(dividend, divisor), EnhancedDoubleHasher.mod(dividend, divisor),
+                assertEquals((int) Long.remainderUnsigned(dividend, divisor), BitMap.mod(dividend, divisor),

Review Comment:
   @garydgregory I think your issue would be solved if @Claudenw moves this test to the BitMapTest. It is no longer applicable to the EnhancedDoubleHasher.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org