[GitHub] [cassandra] jyothsnakonisa commented on a diff in pull request #2372: CASSANDRA-18554 Adding Mutual Tls authenticators for client & internode connections

["jyothsnakonisa (via GitHub)" <gi...@apache.org>]

jyothsnakonisa commented on code in PR #2372:
URL: https://github.com/apache/cassandra/pull/2372#discussion_r1223547596


##########
src/antlr/Parser.g:
##########
@@ -1872,6 +1896,12 @@ username
     | QUOTED_NAME { addRecognitionError("Quoted strings are are not supported for user names and USER is deprecated, please use ROLE");}
     ;
 
+identity

Review Comment:
   Even though they both of them are strings we wanted to define different types for both of them.



##########
conf/cassandra.yaml:
##########
@@ -150,7 +150,14 @@ batchlog_replay_throttle: 1024KiB
 #   users. It keeps usernames and hashed passwords in system_auth.roles table.
 #   Please increase system_auth keyspace replication factor if you use this authenticator.
 #   If using PasswordAuthenticator, CassandraRoleManager must also be used (see below)
-authenticator: AllowAllAuthenticator
+authenticator:
+  class_name : org.apache.cassandra.auth.AllowAllAuthenticator

Review Comment:
   There is backward compatibility. Based on whether the authenticator has parameters or not we create the authenticator.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org