[jira] [Commented] (CB-11100) Upgrade lodash and graceful-fs in cordova-cli

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-11100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15573934#comment-15573934 ] 

ASF GitHub Bot commented on CB-11100:
-------------------------------------

GitHub user stevengill opened a pull request:

    https://github.com/apache/cordova-cli/pull/264

    CB-11100 removed grunt and grunt-retire dev-deps, updated istanbul de…

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    none
    
    ### What does this PR do?
    removes unused dev dependencies, updates the version of istanbul dev dependency to get rid of deprecation notices
    
    ### What testing has been done on this change?
    npm test && npm run cover
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [] Added automated test coverage as appropriate for this change.
    
    …v-dep

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/stevengill/cordova-cli CB-11100

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-cli/pull/264.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #264
    
----
commit b72536597de2341f87868521d3e3d947ccbf24ee
Author: Steve Gill <st...@gmail.com>
Date:   2016-10-14T02:40:55Z

    CB-11100 removed grunt and grunt-retire dev-deps, updated istanbul dev-dep

----


> Upgrade lodash and graceful-fs in cordova-cli
> ---------------------------------------------
>
>                 Key: CB-11100
>                 URL: https://issues.apache.org/jira/browse/CB-11100
>             Project: Apache Cordova
>          Issue Type: Task
>          Components: CLI
>    Affects Versions: 6.2.0
>            Reporter: Omar Mefire
>            Priority: Minor
>              Labels: triaged
>
> When running npm install: (https://ci.apache.org/builders/cordova-android-win/builds/2153/steps/npm-installing-cordova-cli/logs/stdio)
> {noformat}
> npm install --cache C:\Users\buildbot\slaves\apache\cordova-android-win/npm_cache --tmp C:\Users\buildbot\slaves\apache\cordova-android-win/npm_tmp
>  in dir C:\Users\buildbot\slaves\apache\cordova-android-win\cordova-cli (timeout 1500 secs)
> {noformat}
> The following warning messages are generated:
> {noformat}
> npm WARN deprecated lodash@0.9.2: Grunt needs your help! See https://github.com/gruntjs/grunt/issues/1403.
> npm WARN deprecated lodash@2.4.2: lodash@<3.0.0 is no longer maintained. Upgrade to lodash@^4.0.0.
> npm WARN deprecated graceful-fs@1.2.3: graceful-fs version 3 and before will fail on newer node releases. Please update to graceful-fs@^4.0.0 as soon as possible.
> npm WARN deprecated graceful-fs@3.0.8: graceful-fs version 3 and before will fail on newer node releases. Please update to graceful-fs@^4.0.0 as soon as possible.
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org