You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by bu...@apache.org on 2006/02/28 13:44:32 UTC
DO NOT REPLY [Bug 38807] New: - Add an errorproperty parameter to task, like the junit task's
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38807>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38807
Summary: Add an errorproperty parameter to <sql> task, like the
junit task's
Product: Ant
Version: 1.6.5
Platform: PC
OS/Version: Windows XP
Status: NEW
Severity: enhancement
Priority: P3
Component: Core tasks
AssignedTo: dev@ant.apache.org
ReportedBy: ats37@hotmail.com
I'm using the <sql> task with a fileset to read in a whole bunch of stored proc
definitions into our unit test database prior to running the tests. Although I
could use onerror="abort" (or stop) to make the build fail if there are any
problems, this only reports the first file. What I'd find more useful would be
to use onerror="continue" in conjunction with an errorproperty attribute (like
the junit task has) so that all the errors appear in my log file, but a property
gets set which I can check later in the build (and either fail or skip the unit
tests).
And, while I'm wishing, a warningproperty property which gets set if the
conn.getWarnings() call returns anything in execSQL() might also be useful.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
DO NOT REPLY [Bug 38807] - Add an errorproperty parameter to task, like the junit task's
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38807>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38807
------- Additional Comments From ats37@hotmail.com 2006-03-02 02:50 -------
Created an attachment (id=17815)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=17815&action=view)
Patch for SQLExec task
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
DO NOT REPLY [Bug 38807] - Add an errorproperty parameter to task, like the junit task's
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38807>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38807
------- Additional Comments From stevel@apache.org 2006-02-28 14:47 -------
I see what you want here andrew, but I'm not sure what we are going to do about
it. To an extent the error handling of ant is a bit, well, messy; we have
limited policy hard coded into the tasks themselves.
Take a look at the ant-contrib project on sf.net, in particular their try/catch
task. Then look at <macrodef> and see what it would take to actually implement
what you want in a macro. something like (
<macrodef name="mysql">
<attribute name="errors"/>
<attribute name="file" />
<sequential>
<trycatch property="errormessage" >
<try>
<sql >
<transaction file="@{file}" />
</sql>
</try>
<catch>
<echo level="verbose" >${errormessage}</echo>
<property name="@{errors}" value="${errormessage}"/>
</catch>
</trycatch>
</sequential>
</macrodef>
If you fill the <sql> bit in with your DB connection, you get a task you can use
like
<mysql errorproperty="errs" file="drop-db.sql" />
<mysql errorproperty="errs" file="create-db.sql" />
<mysql errorproperty="errs" file="create-user.sql" />
<mysql errorproperty="errs" file="populate-db.sql" />
-steve
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
DO NOT REPLY [Bug 38807] - Add an errorproperty parameter to task, like the junit task's
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38807>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38807
------- Additional Comments From ats37@hotmail.com 2006-03-02 02:49 -------
> I see what you want here andrew, but I'm not sure what we are going to do about
> it.
Does the attached patch help the decision any? :-)
>To an extent the error handling of ant is a bit, well, messy; we have
> limited policy hard coded into the tasks themselves.
>
> Take a look at the ant-contrib project on sf.net, in particular their try/catch
> task. Then look at <macrodef> and see what it would take to actually implement
> what you want in a macro. something like (
>
> <macrodef name="mysql">
> <attribute name="errors"/>
> <attribute name="file" />
> <sequential>
> <trycatch property="errormessage" >
> <try>
> <sql >
> <transaction file="@{file}" />
> </sql>
> </try>
> <catch>
> <echo level="verbose" >${errormessage}</echo>
> <property name="@{errors}" value="${errormessage}"/>
> </catch>
> </trycatch>
> </sequential>
> </macrodef>
>
> If you fill the <sql> bit in with your DB connection, you get a task you can use
> like
> <mysql errorproperty="errs" file="drop-db.sql" />
> <mysql errorproperty="errs" file="create-db.sql" />
> <mysql errorproperty="errs" file="create-user.sql" />
> <mysql errorproperty="errs" file="populate-db.sql" />
That won't work with a fileset, though, will it? (I don't much fancy having to
add another line every time there's a new stored proc) And even if I could come
up with a similar macro that passed through a fileset, it would still stop after
the first sql file & statement that threw an error (at least, the first from
each call to the macro), instead of dumping all the errors to the log. Or am I
missing something?
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
DO NOT REPLY [Bug 38807] - Add an errorproperty parameter to task, like the junit task's
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38807>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38807
------- Additional Comments From ats37@hotmail.com 2006-03-03 02:27 -------
Created an attachment (id=17822)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=17822&action=view)
Patch for 1.6.x branch
Same patch, backported to ANT_16_BRANCH.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org