You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by Oleg Kalnichevski <ol...@apache.org> on 2015/01/24 13:16:59 UTC
[VOTE] Release HttpComponents Client 4.4 based on RC1
Please vote on releasing these packages as HttpComponents Client 4.4.
The vote is open for the at least 72 hours, and only votes from
HttpComponents PMC members are binding. The vote passes if at least
three binding +1 votes are cast and there are more +1 than -1 votes.
Release notes:
https://dist.apache.org/repos/dist/dev/httpcomponents/httpclient-4.4-RC1/RELEASE_NOTES-4.4.x.txt
Maven artefacts:
https://repository.apache.org/content/repositories/orgapachehttpcomponents-1025/org/apache/httpcomponents/
SVN tag:
https://svn.apache.org/repos/asf/httpcomponents/httpclient/tags/4.4-RC1
revision 1654497
Packages:
https://dist.apache.org/repos/dist/dev/httpcomponents/httpclient-4.4-RC1
revision 7821
Hashes:
1b0ed708a8060ca810dbbec86a423fa1 httpcomponents-client-4.4-bin.tar.gz
7cf0df5a8d29b08185f909a4099a8030 httpcomponents-client-4.4-osgi-bin.tar.gz
ecd1bef037b09fbea5099d7a1fb60b86 httpcomponents-client-4.4-src.tar.gz
72125e41d582cb29e3b95a73a0a2eb79 httpcomponents-client-4.4-bin.zip
1c801772176fbcc4385fd0ac8454c310 httpcomponents-client-4.4-osgi-bin.zip
1be9742adc7da4ae8fd1cf70eff0cea4 httpcomponents-client-4.4-src.zip
Keys:
http://www.apache.org/dist/httpcomponents/httpclient/KEYS
--------------------------------------------------------------------------
Vote: HttpComponents Client 4.4 release
[ ] +1 Release the packages as HttpComponents Client 4.4.
[ ] -1 I am against releasing the packages (must include a reason).
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: [VOTE] Release HttpComponents Client 4.4 based on RC1
Posted by "Asankha C. Perera" <as...@adroitlogic.com>.
On 01/24/2015 05:46 PM, Oleg Kalnichevski wrote:
--------------------------------------------------------------------------
Vote: HttpComponents Client 4.4 release
[X] +1 Release the packages as HttpComponents Client 4.4.
[ ] -1 I am against releasing the packages (must include a reason).
All looks good to me including the source build on Linux
regards
asankha
--
Asankha C. Perera
Founder and CTO, AdroitLogic, http://adroitlogic.org
AS2Gateway http://as2gateway.org
VP Apache HttpComponents
http://esbmagic.blogspot.com
Email: asankha@adroitlogic.com
Mobile: +94 722 805724
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: [VOTE] Release HttpComponents Client 4.4 based on RC1
Posted by Gary Gregory <ga...@gmail.com>.
On Sat, Jan 24, 2015 at 2:36 PM, Gary Gregory <ga...@gmail.com>
wrote:
> On Sat, Jan 24, 2015 at 2:34 PM, Gary Gregory <ga...@gmail.com>
> wrote:
>
>> On Sat, Jan 24, 2015 at 2:33 PM, Gary Gregory <ga...@gmail.com>
>> wrote:
>>
>>> Running 'mvn test' I get:
>>>
>>> Failed tests:
>>> TestHttpRoute.testTargetHostNormalizationAddress:619
>>> expected:<[localhost]> but was:<[127.0.0.1]>
>>>
>>> Using:
>>>
>>
>> Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1;
>> 2014-12-14T12:29:23-05:00)
>> Maven home: C:\Java\apache-maven-3.2.5
>> Java version: 1.7.0_75, vendor: Oracle Corporation
>> Java home: C:\Program Files\Java\jdk1.7.0_75\jre
>> Default locale: en_US, platform encoding: Cp1252
>> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
>>
>
> This is with the src zip BTW.
>
Same problem with Java 8:
Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1;
2014-12-14T12:29:23-05:00)
Maven home: C:\Java\apache-maven-3.2.5
Java version: 1.8.0_31, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.8.0_31\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos"
Gary
>
> Gary
>
>
>>
>> Gary
>>
>>
>>>
>>>
>>> On Sat, Jan 24, 2015 at 7:16 AM, Oleg Kalnichevski <ol...@apache.org>
>>> wrote:
>>>
>>>> Please vote on releasing these packages as HttpComponents Client 4.4.
>>>> The vote is open for the at least 72 hours, and only votes from
>>>> HttpComponents PMC members are binding. The vote passes if at least
>>>> three binding +1 votes are cast and there are more +1 than -1 votes.
>>>>
>>>> Release notes:
>>>>
>>>> https://dist.apache.org/repos/dist/dev/httpcomponents/httpclient-4.4-RC1/RELEASE_NOTES-4.4.x.txt
>>>>
>>>> Maven artefacts:
>>>>
>>>> https://repository.apache.org/content/repositories/orgapachehttpcomponents-1025/org/apache/httpcomponents/
>>>>
>>>> SVN tag:
>>>>
>>>> https://svn.apache.org/repos/asf/httpcomponents/httpclient/tags/4.4-RC1
>>>> revision 1654497
>>>>
>>>> Packages:
>>>>
>>>> https://dist.apache.org/repos/dist/dev/httpcomponents/httpclient-4.4-RC1
>>>> revision 7821
>>>>
>>>> Hashes:
>>>> 1b0ed708a8060ca810dbbec86a423fa1 httpcomponents-client-4.4-bin.tar.gz
>>>> 7cf0df5a8d29b08185f909a4099a8030
>>>> httpcomponents-client-4.4-osgi-bin.tar.gz
>>>> ecd1bef037b09fbea5099d7a1fb60b86 httpcomponents-client-4.4-src.tar.gz
>>>> 72125e41d582cb29e3b95a73a0a2eb79 httpcomponents-client-4.4-bin.zip
>>>> 1c801772176fbcc4385fd0ac8454c310 httpcomponents-client-4.4-osgi-bin.zip
>>>> 1be9742adc7da4ae8fd1cf70eff0cea4 httpcomponents-client-4.4-src.zip
>>>>
>>>> Keys:
>>>> http://www.apache.org/dist/httpcomponents/httpclient/KEYS
>>>>
>>>>
>>>> --------------------------------------------------------------------------
>>>> Vote: HttpComponents Client 4.4 release
>>>> [ ] +1 Release the packages as HttpComponents Client 4.4.
>>>> [ ] -1 I am against releasing the packages (must include a reason).
>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
>>>> For additional commands, e-mail: dev-help@hc.apache.org
>>>>
>>>>
>>>
>>>
>>> --
>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>> Java Persistence with Hibernate, Second Edition
>>> <http://www.manning.com/bauer3/>
>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>> Spring Batch in Action <http://www.manning.com/templier/>
>>> Blog: http://garygregory.wordpress.com
>>> Home: http://garygregory.com/
>>> Tweet! http://twitter.com/GaryGregory
>>>
>>
>>
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition
>> <http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [VOTE] Release HttpComponents Client 4.4 based on RC1
Posted by Gary Gregory <ga...@gmail.com>.
On Sat, Jan 24, 2015 at 2:34 PM, Gary Gregory <ga...@gmail.com>
wrote:
> On Sat, Jan 24, 2015 at 2:33 PM, Gary Gregory <ga...@gmail.com>
> wrote:
>
>> Running 'mvn test' I get:
>>
>> Failed tests:
>> TestHttpRoute.testTargetHostNormalizationAddress:619
>> expected:<[localhost]> but was:<[127.0.0.1]>
>>
>> Using:
>>
>
> Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1;
> 2014-12-14T12:29:23-05:00)
> Maven home: C:\Java\apache-maven-3.2.5
> Java version: 1.7.0_75, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.7.0_75\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
>
This is with the src zip BTW.
Gary
>
> Gary
>
>
>>
>>
>> On Sat, Jan 24, 2015 at 7:16 AM, Oleg Kalnichevski <ol...@apache.org>
>> wrote:
>>
>>> Please vote on releasing these packages as HttpComponents Client 4.4.
>>> The vote is open for the at least 72 hours, and only votes from
>>> HttpComponents PMC members are binding. The vote passes if at least
>>> three binding +1 votes are cast and there are more +1 than -1 votes.
>>>
>>> Release notes:
>>>
>>> https://dist.apache.org/repos/dist/dev/httpcomponents/httpclient-4.4-RC1/RELEASE_NOTES-4.4.x.txt
>>>
>>> Maven artefacts:
>>>
>>> https://repository.apache.org/content/repositories/orgapachehttpcomponents-1025/org/apache/httpcomponents/
>>>
>>> SVN tag:
>>> https://svn.apache.org/repos/asf/httpcomponents/httpclient/tags/4.4-RC1
>>> revision 1654497
>>>
>>> Packages:
>>>
>>> https://dist.apache.org/repos/dist/dev/httpcomponents/httpclient-4.4-RC1
>>> revision 7821
>>>
>>> Hashes:
>>> 1b0ed708a8060ca810dbbec86a423fa1 httpcomponents-client-4.4-bin.tar.gz
>>> 7cf0df5a8d29b08185f909a4099a8030
>>> httpcomponents-client-4.4-osgi-bin.tar.gz
>>> ecd1bef037b09fbea5099d7a1fb60b86 httpcomponents-client-4.4-src.tar.gz
>>> 72125e41d582cb29e3b95a73a0a2eb79 httpcomponents-client-4.4-bin.zip
>>> 1c801772176fbcc4385fd0ac8454c310 httpcomponents-client-4.4-osgi-bin.zip
>>> 1be9742adc7da4ae8fd1cf70eff0cea4 httpcomponents-client-4.4-src.zip
>>>
>>> Keys:
>>> http://www.apache.org/dist/httpcomponents/httpclient/KEYS
>>>
>>>
>>> --------------------------------------------------------------------------
>>> Vote: HttpComponents Client 4.4 release
>>> [ ] +1 Release the packages as HttpComponents Client 4.4.
>>> [ ] -1 I am against releasing the packages (must include a reason).
>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
>>> For additional commands, e-mail: dev-help@hc.apache.org
>>>
>>>
>>
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition
>> <http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [VOTE] Release HttpComponents Client 4.4 based on RC1
Posted by Gary Gregory <ga...@gmail.com>.
On Sat, Jan 24, 2015 at 2:33 PM, Gary Gregory <ga...@gmail.com>
wrote:
> Running 'mvn test' I get:
>
> Failed tests:
> TestHttpRoute.testTargetHostNormalizationAddress:619
> expected:<[localhost]> but was:<[127.0.0.1]>
>
> Using:
>
Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1;
2014-12-14T12:29:23-05:00)
Maven home: C:\Java\apache-maven-3.2.5
Java version: 1.7.0_75, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.7.0_75\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
Gary
>
>
> On Sat, Jan 24, 2015 at 7:16 AM, Oleg Kalnichevski <ol...@apache.org>
> wrote:
>
>> Please vote on releasing these packages as HttpComponents Client 4.4.
>> The vote is open for the at least 72 hours, and only votes from
>> HttpComponents PMC members are binding. The vote passes if at least
>> three binding +1 votes are cast and there are more +1 than -1 votes.
>>
>> Release notes:
>>
>> https://dist.apache.org/repos/dist/dev/httpcomponents/httpclient-4.4-RC1/RELEASE_NOTES-4.4.x.txt
>>
>> Maven artefacts:
>>
>> https://repository.apache.org/content/repositories/orgapachehttpcomponents-1025/org/apache/httpcomponents/
>>
>> SVN tag:
>> https://svn.apache.org/repos/asf/httpcomponents/httpclient/tags/4.4-RC1
>> revision 1654497
>>
>> Packages:
>> https://dist.apache.org/repos/dist/dev/httpcomponents/httpclient-4.4-RC1
>> revision 7821
>>
>> Hashes:
>> 1b0ed708a8060ca810dbbec86a423fa1 httpcomponents-client-4.4-bin.tar.gz
>> 7cf0df5a8d29b08185f909a4099a8030
>> httpcomponents-client-4.4-osgi-bin.tar.gz
>> ecd1bef037b09fbea5099d7a1fb60b86 httpcomponents-client-4.4-src.tar.gz
>> 72125e41d582cb29e3b95a73a0a2eb79 httpcomponents-client-4.4-bin.zip
>> 1c801772176fbcc4385fd0ac8454c310 httpcomponents-client-4.4-osgi-bin.zip
>> 1be9742adc7da4ae8fd1cf70eff0cea4 httpcomponents-client-4.4-src.zip
>>
>> Keys:
>> http://www.apache.org/dist/httpcomponents/httpclient/KEYS
>>
>> --------------------------------------------------------------------------
>> Vote: HttpComponents Client 4.4 release
>> [ ] +1 Release the packages as HttpComponents Client 4.4.
>> [ ] -1 I am against releasing the packages (must include a reason).
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
>> For additional commands, e-mail: dev-help@hc.apache.org
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
RC called off; Re: [VOTE] Release HttpComponents Client 4.4 based
on RC1
Posted by Oleg Kalnichevski <ol...@apache.org>.
On Mon, 2015-01-26 at 15:09 -0500, Gary Gregory wrote:
> On Mon, Jan 26, 2015 at 8:45 AM, Oleg Kalnichevski <ol...@apache.org> wrote:
>
> > On Mon, 2015-01-26 at 08:03 -0500, Gary Gregory wrote:
> > > On Mon, Jan 26, 2015 at 4:11 AM, Oleg Kalnichevski <ol...@apache.org>
> > wrote:
> > >
> > > > On Sat, 2015-01-24 at 14:33 -0500, Gary Gregory wrote:
> > > > > Running 'mvn test' I get:
> > > > >
> > > > > Failed tests:
> > > > > TestHttpRoute.testTargetHostNormalizationAddress:619
> > > > > expected:<[localhost]> but was:<[127.0.0.1]>
> > > > >
> > > > > Using:
> > > > >
> > > >
> > > > Gary
> > > >
> > > > This is clearly not a defect, but what appears to be Windows specific
> > > > behavior.
> > > >
> > >
> > > If you say so, I am only testing on Windows. There is no way for me to
> > know
> > > or tell that this is Windows specific. I see you removed:
> > >
> > > Assert.assertEquals("localhost", targetHost.getHostName());
> > >
> > > If this is expected to pass on non-Windows then perhaps the assert should
> > > be in a special test method with a JUnit Assume that only passes on
> > > non-Windows.
> > >
> > > Or is the behavior of the method "underfined" WRT to 'transformations'?
> > >
> > > Did the behavior change between releases? Is this going to be a
> > > compatibility issue?
> > >
> >
> > I do not think so. The problem stems from platform dependent results of
> > resolving 127.0.0.1 to a host name. Unix-like OSes resolve this address
> > to 'localhost' whereas Windows resolves it to '127.0.0.1'.
> >
>
> Thank you for the explanation.
>
> This:
>
> public class IpToHostName {
>
> public static void main(String[] args) {
> for (int i = 0; i < args.length; i++) {
> InetAddress addr;
> try {
> String addrStr = args[i];
> addr = InetAddress.getByName(addrStr);
> String host = addr.getHostName();
> System.out.println(String.format("%s -> %s", addrStr,
> host));
> } catch (UnknownHostException e) {
> e.printStackTrace();
> }
> }
> }
>
> }
>
> With input
>
> 127.0.0.1
>
> produces
>
> 127.0.0.1 -> 127.0.0.1
>
> Lovely. So we are stuck with this behavior and the test does not know about
> this quirk and fails. Bleh.
>
> I only feel good about +'ing a src zip for an RC I can build, so I will not
> vote. If creating RC's were not such a pain...
>
> If this RC becomes a release, then a note on the site must talk about this
> as an expected build failure on Windows IMO.
>
> Gary
>
We had another bug fix and some tutorial updates in the meantime. I'll
cut another RC tomorrow.
Oleg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: [VOTE] Release HttpComponents Client 4.4 based on RC1
Posted by Gary Gregory <ga...@gmail.com>.
On Mon, Jan 26, 2015 at 8:45 AM, Oleg Kalnichevski <ol...@apache.org> wrote:
> On Mon, 2015-01-26 at 08:03 -0500, Gary Gregory wrote:
> > On Mon, Jan 26, 2015 at 4:11 AM, Oleg Kalnichevski <ol...@apache.org>
> wrote:
> >
> > > On Sat, 2015-01-24 at 14:33 -0500, Gary Gregory wrote:
> > > > Running 'mvn test' I get:
> > > >
> > > > Failed tests:
> > > > TestHttpRoute.testTargetHostNormalizationAddress:619
> > > > expected:<[localhost]> but was:<[127.0.0.1]>
> > > >
> > > > Using:
> > > >
> > >
> > > Gary
> > >
> > > This is clearly not a defect, but what appears to be Windows specific
> > > behavior.
> > >
> >
> > If you say so, I am only testing on Windows. There is no way for me to
> know
> > or tell that this is Windows specific. I see you removed:
> >
> > Assert.assertEquals("localhost", targetHost.getHostName());
> >
> > If this is expected to pass on non-Windows then perhaps the assert should
> > be in a special test method with a JUnit Assume that only passes on
> > non-Windows.
> >
> > Or is the behavior of the method "underfined" WRT to 'transformations'?
> >
> > Did the behavior change between releases? Is this going to be a
> > compatibility issue?
> >
>
> I do not think so. The problem stems from platform dependent results of
> resolving 127.0.0.1 to a host name. Unix-like OSes resolve this address
> to 'localhost' whereas Windows resolves it to '127.0.0.1'.
>
Thank you for the explanation.
This:
public class IpToHostName {
public static void main(String[] args) {
for (int i = 0; i < args.length; i++) {
InetAddress addr;
try {
String addrStr = args[i];
addr = InetAddress.getByName(addrStr);
String host = addr.getHostName();
System.out.println(String.format("%s -> %s", addrStr,
host));
} catch (UnknownHostException e) {
e.printStackTrace();
}
}
}
}
With input
127.0.0.1
produces
127.0.0.1 -> 127.0.0.1
Lovely. So we are stuck with this behavior and the test does not know about
this quirk and fails. Bleh.
I only feel good about +'ing a src zip for an RC I can build, so I will not
vote. If creating RC's were not such a pain...
If this RC becomes a release, then a note on the site must talk about this
as an expected build failure on Windows IMO.
Gary
>
> Oleg
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [VOTE] Release HttpComponents Client 4.4 based on RC1
Posted by Oleg Kalnichevski <ol...@apache.org>.
On Mon, 2015-01-26 at 08:03 -0500, Gary Gregory wrote:
> On Mon, Jan 26, 2015 at 4:11 AM, Oleg Kalnichevski <ol...@apache.org> wrote:
>
> > On Sat, 2015-01-24 at 14:33 -0500, Gary Gregory wrote:
> > > Running 'mvn test' I get:
> > >
> > > Failed tests:
> > > TestHttpRoute.testTargetHostNormalizationAddress:619
> > > expected:<[localhost]> but was:<[127.0.0.1]>
> > >
> > > Using:
> > >
> >
> > Gary
> >
> > This is clearly not a defect, but what appears to be Windows specific
> > behavior.
> >
>
> If you say so, I am only testing on Windows. There is no way for me to know
> or tell that this is Windows specific. I see you removed:
>
> Assert.assertEquals("localhost", targetHost.getHostName());
>
> If this is expected to pass on non-Windows then perhaps the assert should
> be in a special test method with a JUnit Assume that only passes on
> non-Windows.
>
> Or is the behavior of the method "underfined" WRT to 'transformations'?
>
> Did the behavior change between releases? Is this going to be a
> compatibility issue?
>
I do not think so. The problem stems from platform dependent results of
resolving 127.0.0.1 to a host name. Unix-like OSes resolve this address
to 'localhost' whereas Windows resolves it to '127.0.0.1'.
Oleg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: [VOTE] Release HttpComponents Client 4.4 based on RC1
Posted by Gary Gregory <ga...@gmail.com>.
On Mon, Jan 26, 2015 at 4:11 AM, Oleg Kalnichevski <ol...@apache.org> wrote:
> On Sat, 2015-01-24 at 14:33 -0500, Gary Gregory wrote:
> > Running 'mvn test' I get:
> >
> > Failed tests:
> > TestHttpRoute.testTargetHostNormalizationAddress:619
> > expected:<[localhost]> but was:<[127.0.0.1]>
> >
> > Using:
> >
>
> Gary
>
> This is clearly not a defect, but what appears to be Windows specific
> behavior.
>
If you say so, I am only testing on Windows. There is no way for me to know
or tell that this is Windows specific. I see you removed:
Assert.assertEquals("localhost", targetHost.getHostName());
If this is expected to pass on non-Windows then perhaps the assert should
be in a special test method with a JUnit Assume that only passes on
non-Windows.
Or is the behavior of the method "underfined" WRT to 'transformations'?
Did the behavior change between releases? Is this going to be a
compatibility issue?
>
> I removed the assert in SVN trunk:
> http://svn.apache.org/r1654745
>
> Is this issue a release blocker for you?
>
You make it sound like it shouldn't be a blocker but that means anyone
evaluating the RC on Windows will run into this failure. I guess I could
tell Maven to skip the one test but I do not think I can do that from the
command line as opposed to the POM.
Since it seems you are confident this is not an issue and I cannot run a
full build, I will vote 0: cannot run full build on Windows, one test fails"
Gary
> Oleg
>
> >
> > On Sat, Jan 24, 2015 at 7:16 AM, Oleg Kalnichevski <ol...@apache.org>
> wrote:
> >
> > > Please vote on releasing these packages as HttpComponents Client 4.4.
> > > The vote is open for the at least 72 hours, and only votes from
> > > HttpComponents PMC members are binding. The vote passes if at least
> > > three binding +1 votes are cast and there are more +1 than -1 votes.
> > >
> > > Release notes:
> > >
> > >
> https://dist.apache.org/repos/dist/dev/httpcomponents/httpclient-4.4-RC1/RELEASE_NOTES-4.4.x.txt
> > >
> > > Maven artefacts:
> > >
> > >
> https://repository.apache.org/content/repositories/orgapachehttpcomponents-1025/org/apache/httpcomponents/
> > >
> > > SVN tag:
> > >
> https://svn.apache.org/repos/asf/httpcomponents/httpclient/tags/4.4-RC1
> > > revision 1654497
> > >
> > > Packages:
> > >
> https://dist.apache.org/repos/dist/dev/httpcomponents/httpclient-4.4-RC1
> > > revision 7821
> > >
> > > Hashes:
> > > 1b0ed708a8060ca810dbbec86a423fa1 httpcomponents-client-4.4-bin.tar.gz
> > > 7cf0df5a8d29b08185f909a4099a8030
> httpcomponents-client-4.4-osgi-bin.tar.gz
> > > ecd1bef037b09fbea5099d7a1fb60b86 httpcomponents-client-4.4-src.tar.gz
> > > 72125e41d582cb29e3b95a73a0a2eb79 httpcomponents-client-4.4-bin.zip
> > > 1c801772176fbcc4385fd0ac8454c310
> httpcomponents-client-4.4-osgi-bin.zip
> > > 1be9742adc7da4ae8fd1cf70eff0cea4 httpcomponents-client-4.4-src.zip
> > >
> > > Keys:
> > > http://www.apache.org/dist/httpcomponents/httpclient/KEYS
> > >
> > >
> --------------------------------------------------------------------------
> > > Vote: HttpComponents Client 4.4 release
> > > [ ] +1 Release the packages as HttpComponents Client 4.4.
> > > [ ] -1 I am against releasing the packages (must include a reason).
> > >
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> > > For additional commands, e-mail: dev-help@hc.apache.org
> > >
> > >
> >
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [VOTE] Release HttpComponents Client 4.4 based on RC1
Posted by Oleg Kalnichevski <ol...@apache.org>.
On Sat, 2015-01-24 at 14:33 -0500, Gary Gregory wrote:
> Running 'mvn test' I get:
>
> Failed tests:
> TestHttpRoute.testTargetHostNormalizationAddress:619
> expected:<[localhost]> but was:<[127.0.0.1]>
>
> Using:
>
Gary
This is clearly not a defect, but what appears to be Windows specific
behavior.
I removed the assert in SVN trunk:
http://svn.apache.org/r1654745
Is this issue a release blocker for you?
Oleg
>
> On Sat, Jan 24, 2015 at 7:16 AM, Oleg Kalnichevski <ol...@apache.org> wrote:
>
> > Please vote on releasing these packages as HttpComponents Client 4.4.
> > The vote is open for the at least 72 hours, and only votes from
> > HttpComponents PMC members are binding. The vote passes if at least
> > three binding +1 votes are cast and there are more +1 than -1 votes.
> >
> > Release notes:
> >
> > https://dist.apache.org/repos/dist/dev/httpcomponents/httpclient-4.4-RC1/RELEASE_NOTES-4.4.x.txt
> >
> > Maven artefacts:
> >
> > https://repository.apache.org/content/repositories/orgapachehttpcomponents-1025/org/apache/httpcomponents/
> >
> > SVN tag:
> > https://svn.apache.org/repos/asf/httpcomponents/httpclient/tags/4.4-RC1
> > revision 1654497
> >
> > Packages:
> > https://dist.apache.org/repos/dist/dev/httpcomponents/httpclient-4.4-RC1
> > revision 7821
> >
> > Hashes:
> > 1b0ed708a8060ca810dbbec86a423fa1 httpcomponents-client-4.4-bin.tar.gz
> > 7cf0df5a8d29b08185f909a4099a8030 httpcomponents-client-4.4-osgi-bin.tar.gz
> > ecd1bef037b09fbea5099d7a1fb60b86 httpcomponents-client-4.4-src.tar.gz
> > 72125e41d582cb29e3b95a73a0a2eb79 httpcomponents-client-4.4-bin.zip
> > 1c801772176fbcc4385fd0ac8454c310 httpcomponents-client-4.4-osgi-bin.zip
> > 1be9742adc7da4ae8fd1cf70eff0cea4 httpcomponents-client-4.4-src.zip
> >
> > Keys:
> > http://www.apache.org/dist/httpcomponents/httpclient/KEYS
> >
> > --------------------------------------------------------------------------
> > Vote: HttpComponents Client 4.4 release
> > [ ] +1 Release the packages as HttpComponents Client 4.4.
> > [ ] -1 I am against releasing the packages (must include a reason).
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> > For additional commands, e-mail: dev-help@hc.apache.org
> >
> >
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: [VOTE] Release HttpComponents Client 4.4 based on RC1
Posted by Gary Gregory <ga...@gmail.com>.
Running 'mvn test' I get:
Failed tests:
TestHttpRoute.testTargetHostNormalizationAddress:619
expected:<[localhost]> but was:<[127.0.0.1]>
Using:
On Sat, Jan 24, 2015 at 7:16 AM, Oleg Kalnichevski <ol...@apache.org> wrote:
> Please vote on releasing these packages as HttpComponents Client 4.4.
> The vote is open for the at least 72 hours, and only votes from
> HttpComponents PMC members are binding. The vote passes if at least
> three binding +1 votes are cast and there are more +1 than -1 votes.
>
> Release notes:
>
> https://dist.apache.org/repos/dist/dev/httpcomponents/httpclient-4.4-RC1/RELEASE_NOTES-4.4.x.txt
>
> Maven artefacts:
>
> https://repository.apache.org/content/repositories/orgapachehttpcomponents-1025/org/apache/httpcomponents/
>
> SVN tag:
> https://svn.apache.org/repos/asf/httpcomponents/httpclient/tags/4.4-RC1
> revision 1654497
>
> Packages:
> https://dist.apache.org/repos/dist/dev/httpcomponents/httpclient-4.4-RC1
> revision 7821
>
> Hashes:
> 1b0ed708a8060ca810dbbec86a423fa1 httpcomponents-client-4.4-bin.tar.gz
> 7cf0df5a8d29b08185f909a4099a8030 httpcomponents-client-4.4-osgi-bin.tar.gz
> ecd1bef037b09fbea5099d7a1fb60b86 httpcomponents-client-4.4-src.tar.gz
> 72125e41d582cb29e3b95a73a0a2eb79 httpcomponents-client-4.4-bin.zip
> 1c801772176fbcc4385fd0ac8454c310 httpcomponents-client-4.4-osgi-bin.zip
> 1be9742adc7da4ae8fd1cf70eff0cea4 httpcomponents-client-4.4-src.zip
>
> Keys:
> http://www.apache.org/dist/httpcomponents/httpclient/KEYS
>
> --------------------------------------------------------------------------
> Vote: HttpComponents Client 4.4 release
> [ ] +1 Release the packages as HttpComponents Client 4.4.
> [ ] -1 I am against releasing the packages (must include a reason).
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory