You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by "bzablocki (via GitHub)" <gi...@apache.org> on 2023/05/30 11:30:29 UTC

[GitHub] [beam] bzablocki opened a new pull request, #26936: Make lulls message in Python SDK to be consistent with the implementation in Java SDK

bzablocki opened a new pull request, #26936:
URL: https://github.com/apache/beam/pull/26936

   Resolves #26278 
   
   Implementation in Java: [link](https://github.com/bzablocki/beam/blob/ff270573316b29c5a1d303ed53335ef6f7916635/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ExecutionStateSampler.java
   https://github.com/apache/beam/blob/ff270573316b29c5a1d303ed53335ef6f7916635/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ExecutionStateSampler.java)
   
   The message in Java is in the following format:
   ```
   String.format(
       "Operation ongoing in bundle %s for PTransform{id=%s, name=%s, state=%s} for at least %s without outputting or completing:%n  at %s",
       processBundleId.get(),
       currentExecutionState.ptransformId,
       currentExecutionState.ptransformUniqueName,
       currentExecutionState.stateName,
       DURATION_FORMATTER.print(Duration.millis(lullTimeMs).toPeriod()),
       Joiner.on("\n  at ").join(thread.getStackTrace())));
   ```
   
   The implementation in this PR will bring Python's lulls message closer to Java's format.
   ```
   step_name_log = (
       ' for PTransform{name=%s, state=%s}' % (step_name, state_name))
        
   stack_trace = self._get_stack_trace(sampler_info)
   
   _LOGGER.warning(
       (
           'Operation ongoing in bundle %s%s for at least %.2f seconds'
           ' without outputting or completing.\n'
           'Current Traceback:\n%s'),
       instruction,
       step_name_log,
       lull_seconds,
       stack_trace,
   )
   ```
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #26936: Make lulls message in Python SDK to be consistent with the implementation in Java SDK

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #26936:
URL: https://github.com/apache/beam/pull/26936#issuecomment-1568452440

   Ok - I'll remind @bzablocki after tests pass


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org