[GitHub] [incubator-nuttx] btashton edited a comment on pull request #3586: Revert a change that accepted UDP packets not destined for us.

[GitBox <gi...@apache.org>]

btashton edited a comment on pull request #3586:
URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824577959


   > @antmerlino @patacongo @btashton In fact, this issue only occurs when the network card address has not been obtained, I think we can add the check (dev->d_ipaddr == INADDR_ANY) to ensure that UDP packets are received only when there is any address. What do you think?
   
   I don't think that is quite right.  If a device has an IP address already it should still be able to make the unicast DHCP request.  I think the filter should be L2 address.
   
   https://tools.ietf.org/html/rfc1542#section-4.1.2
   
   > If the BROADCAST flag is cleared (0), the reply SHOULD be
      sent as an IP unicast to the IP address specified by the 'yiaddr'
      field and the link-layer address specified in the 'chaddr' field.  If
      unicasting is not possible, the reply MAY be sent as a broadcast, in
      which case it SHOULD be sent to the link-layer broadcast address
      using the IP limited broadcast address 255.255.255.255 as the IP
      destination address.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org