You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sam Tunnicliffe (JIRA)" <ji...@apache.org> on 2018/02/07 17:36:00 UTC
[jira] [Commented] (CASSANDRA-14206) pytest/python 3 dtests breaks
tests on 3.0 and 3.11
[ https://issues.apache.org/jira/browse/CASSANDRA-14206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355784#comment-16355784 ]
Sam Tunnicliffe commented on CASSANDRA-14206:
---------------------------------------------
+1 The only failures I see now look legit.
The only nit is a debug statement left in conftest.py (line #375).
Thanks!
> pytest/python 3 dtests breaks tests on 3.0 and 3.11
> ---------------------------------------------------
>
> Key: CASSANDRA-14206
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14206
> Project: Cassandra
> Issue Type: Test
> Components: Testing
> Reporter: Ariel Weisberg
> Assignee: Ariel Weisberg
> Priority: Major
> Attachments: loose_version.diff
>
>
> In 2.7 it uses the cmp built-in to compare the list of version components which accepts comparisons of strings and integers. In python 3 it manually compares each using <, ==, and > which can fail if the the types don't match.
> Switch to using our own comparison function that preserves the old behavior.
> Additionally the new thrift bindings don't accept strings where they used to. The strings need to be provided use utf-8 encoded bytes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org