You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Fine <ab...@cloudera.com> on 2016/01/04 19:47:23 UTC
Re: Review Request 41709: SQOOP-2755 Sqoop2:Docs: Add section for
examples and describe S3 import
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41709/#review112615
-----------------------------------------------------------
docs/src/site/sphinx/user/Examples.rst (line 18)
<https://reviews.apache.org/r/41709/#comment173127>
do we have jiras to create use cases for other common examples?
docs/src/site/sphinx/user/examples/S3Iimport.rst (line 1)
<https://reviews.apache.org/r/41709/#comment173126>
the filename is misspelled
docs/src/site/sphinx/user/examples/S3Iimport.rst (line 40)
<https://reviews.apache.org/r/41709/#comment173128>
could we possibly include all of the input and output of the shell when creating these links (perhaps with comments on the side)? I think it would be a little clearer.
docs/src/site/sphinx/user/examples/S3Iimport.rst (line 65)
<https://reviews.apache.org/r/41709/#comment173125>
would it be possible to put a small explanation as to why append mode is being used (tie it back to the original use case)
- Abraham Fine
On Dec. 27, 2015, 7:38 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41709/
> -----------------------------------------------------------
>
> (Updated Dec. 27, 2015, 7:38 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2755
> https://issues.apache.org/jira/browse/SQOOP-2755
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Put together S3 import example as suggested on JIRA.
>
>
> Diffs
> -----
>
> docs/src/site/sphinx/user/Examples.rst PRE-CREATION
> docs/src/site/sphinx/user/examples/S3Iimport.rst PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41709/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 41709: SQOOP-2755 Sqoop2:Docs: Add section for
examples and describe S3 import
Posted by Jarek Cecho <ja...@apache.org>.
> On Jan. 4, 2016, 6:47 p.m., Abraham Fine wrote:
> > docs/src/site/sphinx/user/Examples.rst, line 18
> > <https://reviews.apache.org/r/41709/diff/2/?file=1176483#file1176483line18>
> >
> > do we have jiras to create use cases for other common examples?
Not yet, feel free to create those that you feel would be helpful. I'm intending to add them as we'll discover what is actually helpful.
> On Jan. 4, 2016, 6:47 p.m., Abraham Fine wrote:
> > docs/src/site/sphinx/user/examples/S3Iimport.rst, line 40
> > <https://reviews.apache.org/r/41709/diff/2/?file=1176484#file1176484line40>
> >
> > could we possibly include all of the input and output of the shell when creating these links (perhaps with comments on the side)? I think it would be a little clearer.
I would prefer not to do that because that output will differ from version to version which can work against us in terms of clarity. I'm trying just to highlight how the use case can be done rather then trying to be exhaustive (e.g. for the examples section I'm anticipating that user is already familiar with Sqoop).
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41709/#review112615
-----------------------------------------------------------
On Dec. 27, 2015, 7:38 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41709/
> -----------------------------------------------------------
>
> (Updated Dec. 27, 2015, 7:38 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2755
> https://issues.apache.org/jira/browse/SQOOP-2755
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Put together S3 import example as suggested on JIRA.
>
>
> Diffs
> -----
>
> docs/src/site/sphinx/user/Examples.rst PRE-CREATION
> docs/src/site/sphinx/user/examples/S3Iimport.rst PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41709/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jarek Cecho
>
>