You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2019/02/06 02:05:22 UTC
[Impala-ASF-CR] IMPALA-8098: [DOCS] Port change for the SHUTDOWN command
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12379
Change subject: IMPALA-8098: [DOCS] Port change for the SHUTDOWN command
......................................................................
IMPALA-8098: [DOCS] Port change for the SHUTDOWN command
Change-Id: I77fcc13a67017a062f0be7cb15f22373bf66cb4c
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_shutdown.xml
3 files changed, 25 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/12379/1
--
To view, visit http://gerrit.cloudera.org:8080/12379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I77fcc13a67017a062f0be7cb15f22373bf66cb4c
Gerrit-Change-Number: 12379
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[Impala-ASF-CR] IMPALA-8098: [DOCS] Port change for the SHUTDOWN command
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12379 )
Change subject: IMPALA-8098: [DOCS] Port change for the SHUTDOWN command
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/203/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/12379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I77fcc13a67017a062f0be7cb15f22373bf66cb4c
Gerrit-Change-Number: 12379
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Feb 2019 20:30:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8098: [DOCS] Port change for the SHUTDOWN command
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12379 )
Change subject: IMPALA-8098: [DOCS] Port change for the SHUTDOWN command
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I77fcc13a67017a062f0be7cb15f22373bf66cb4c
Gerrit-Change-Number: 12379
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 09 Feb 2019 00:37:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8098: [DOCS] Port change for the SHUTDOWN command
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12379 )
Change subject: IMPALA-8098: [DOCS] Port change for the SHUTDOWN command
......................................................................
IMPALA-8098: [DOCS] Port change for the SHUTDOWN command
Change-Id: I77fcc13a67017a062f0be7cb15f22373bf66cb4c
Reviewed-on: http://gerrit.cloudera.org:8080/12379
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Andrew Sherman <as...@cloudera.com>
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_shutdown.xml
3 files changed, 25 insertions(+), 3 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Andrew Sherman: Looks good to me, but someone else must approve
Tim Armstrong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I77fcc13a67017a062f0be7cb15f22373bf66cb4c
Gerrit-Change-Number: 12379
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8098: [DOCS] Port change for the SHUTDOWN command
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12379 )
Change subject: IMPALA-8098: [DOCS] Port change for the SHUTDOWN command
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/203/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/12379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I77fcc13a67017a062f0be7cb15f22373bf66cb4c
Gerrit-Change-Number: 12379
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Feb 2019 20:34:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8098: [DOCS] Port change for the SHUTDOWN command
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12379 )
Change subject: IMPALA-8098: [DOCS] Port change for the SHUTDOWN command
......................................................................
Patch Set 2:
> (1 comment)
>
> LGTM
Deleted
--
To view, visit http://gerrit.cloudera.org:8080/12379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I77fcc13a67017a062f0be7cb15f22373bf66cb4c
Gerrit-Change-Number: 12379
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Feb 2019 21:40:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8098: [DOCS] Port change for the SHUTDOWN command
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Andrew Sherman, Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12379
to look at the new patch set (#2).
Change subject: IMPALA-8098: [DOCS] Port change for the SHUTDOWN command
......................................................................
IMPALA-8098: [DOCS] Port change for the SHUTDOWN command
Change-Id: I77fcc13a67017a062f0be7cb15f22373bf66cb4c
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_shutdown.xml
3 files changed, 25 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/12379/2
--
To view, visit http://gerrit.cloudera.org:8080/12379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I77fcc13a67017a062f0be7cb15f22373bf66cb4c
Gerrit-Change-Number: 12379
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8098: [DOCS] Port change for the SHUTDOWN command
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12379 )
Change subject: IMPALA-8098: [DOCS] Port change for the SHUTDOWN command
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
LGTM
http://gerrit.cloudera.org:8080/#/c/12379/1/docs/topics/impala_shutdown.xml
File docs/topics/impala_shutdown.xml:
http://gerrit.cloudera.org:8080/#/c/12379/1/docs/topics/impala_shutdown.xml@112
PS1, Line 112: <stentry>
As I emailed to you, this should be deleted
--
To view, visit http://gerrit.cloudera.org:8080/12379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I77fcc13a67017a062f0be7cb15f22373bf66cb4c
Gerrit-Change-Number: 12379
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Feb 2019 21:31:35 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8098: [DOCS] Port change for the SHUTDOWN command
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12379 )
Change subject: IMPALA-8098: [DOCS] Port change for the SHUTDOWN command
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/202/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/12379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I77fcc13a67017a062f0be7cb15f22373bf66cb4c
Gerrit-Change-Number: 12379
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Feb 2019 02:21:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8098: [DOCS] Port change for the SHUTDOWN command
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12379 )
Change subject: IMPALA-8098: [DOCS] Port change for the SHUTDOWN command
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/202/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/12379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I77fcc13a67017a062f0be7cb15f22373bf66cb4c
Gerrit-Change-Number: 12379
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Feb 2019 02:05:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8098: [DOCS] Port change for the SHUTDOWN command
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12379 )
Change subject: IMPALA-8098: [DOCS] Port change for the SHUTDOWN command
......................................................................
Patch Set 2:
Tim,
Could you review the change and approve?
--
To view, visit http://gerrit.cloudera.org:8080/12379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I77fcc13a67017a062f0be7cb15f22373bf66cb4c
Gerrit-Change-Number: 12379
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Feb 2019 21:40:51 +0000
Gerrit-HasComments: No