You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by li...@apache.org on 2026/09/07 12:01:27 UTC

(skywalking-banyandb-helm) branch logging-container created (now 4b551eb)

This is an automated email from the ASF dual-hosted git repository.

mrproliu pushed a change to branch logging-container
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git


      at 4b551eb  Add an `env` list to the lifecycle sidecar, the backup sidecar and the restore init container

This branch includes the following new commits:

     new 4b551eb  Add an `env` list to the lifecycle sidecar, the backup sidecar and the restore init container

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



(skywalking-banyandb-helm) 01/01: Add an `env` list to the lifecycle sidecar, the backup sidecar and the restore init container

Posted by li...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

mrproliu pushed a commit to branch logging-container
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git

commit 4b551ebeef66944db95703cc6d8e3ac2595ec82d
Author: mrproliu <74...@qq.com>
AuthorDate: Mon Sep 7 20:01:06 2026 +0800

    Add an `env` list to the lifecycle sidecar, the backup sidecar and the restore init container
---
 CHANGES.md                                    |  1 +
 chart/templates/cluster_data_statefulset.yaml | 12 ++++++++++++
 chart/values.yaml                             |  9 +++++++++
 doc/parameters.md                             |  3 +++
 4 files changed, 25 insertions(+)

diff --git a/CHANGES.md b/CHANGES.md
index 03b2672..60526ff 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -28,6 +28,7 @@ Release Notes.
 - Validate generated resource names (StatefulSets, Services, Secrets,
   Deployments) at install/upgrade time to avoid exceeding Kubernetes' 63-byte
   label limit, failing fast with a clear error instead of at apply time.
+- Add an `env` list to the lifecycle sidecar, the backup sidecar and the restore init container.
 
 0.6.0
 -----------------
diff --git a/chart/templates/cluster_data_statefulset.yaml b/chart/templates/cluster_data_statefulset.yaml
index 3694b08..42fa3f5 100644
--- a/chart/templates/cluster_data_statefulset.yaml
+++ b/chart/templates/cluster_data_statefulset.yaml
@@ -112,6 +112,10 @@ spec:
               valueFrom:
                 fieldRef:
                   fieldPath: metadata.labels['apps.kubernetes.io/pod-index']
+            {{- range $env := $roleConfig.restoreInitContainer.env }}
+            - name: {{ $env.name }}
+              value: {{ $env.value | toString | quote }}
+            {{- end }}
           {{- if $.Values.storage.data.enabled }}
           volumeMounts:
             {{- range $claim := $.Values.storage.data.persistentVolumeClaims }}
@@ -484,6 +488,10 @@ spec:
               valueFrom:
                 fieldRef:
                   fieldPath: metadata.labels['apps.kubernetes.io/pod-index']
+            {{- range $env := $roleConfig.backupSidecar.env }}
+            - name: {{ $env.name }}
+              value: {{ $env.value | toString | quote }}
+            {{- end }}
           {{- if $.Values.storage.data.enabled }}
           volumeMounts:
             {{- range $claim := $.Values.storage.data.persistentVolumeClaims }}
@@ -528,6 +536,10 @@ spec:
             - name: BYDB_NODE_LABELS
               value: "type={{ $roleName }}"
             {{- include "banyandb.nodeDiscoveryEnv" (dict "root" $) | nindent 12 }}
+            {{- range $env := $roleConfig.lifecycleSidecar.env }}
+            - name: {{ $env.name }}
+              value: {{ $env.value | toString | quote }}
+            {{- end }}
           command:
             - "/lifecycle"
             - "--schedule={{ $roleConfig.lifecycleSidecar.schedule }}"
diff --git a/chart/values.yaml b/chart/values.yaml
index 587b520..63f152f 100644
--- a/chart/values.yaml
+++ b/chart/values.yaml
@@ -797,6 +797,9 @@ cluster:
       ## Backup sidecar configuration for data pods
       ##
       backupSidecar:
+        ## @param cluster.data.nodeTemplate.backupSidecar.env Environment variables for the backup sidecar
+        ##
+        env: []
         ## @param cluster.data.nodeTemplate.backupSidecar.enabled Enable backup sidecar for data pods (boolean)
         ##
         enabled: false
@@ -818,6 +821,9 @@ cluster:
       ## Lifecycle sidecar configuration for data pods
       ##
       lifecycleSidecar:
+        ## @param cluster.data.nodeTemplate.lifecycleSidecar.env Environment variables for the lifecycle sidecar
+        ##
+        env: []
         ## @param cluster.data.nodeTemplate.lifecycleSidecar.enabled Enable lifecycle sidecar for data pods (boolean)
         ##
         enabled: false
@@ -836,6 +842,9 @@ cluster:
       ## Restore init container configuration for data pods
       ##
       restoreInitContainer:
+        ## @param cluster.data.nodeTemplate.restoreInitContainer.env Environment variables for the restore init container
+        ##
+        env: []
         ## @param cluster.data.nodeTemplate.restoreInitContainer.enabled Enable restore init container for data pods (boolean)
         ##
         enabled: false
diff --git a/doc/parameters.md b/doc/parameters.md
index 0cb14dd..749eaa7 100644
--- a/doc/parameters.md
+++ b/doc/parameters.md
@@ -294,17 +294,20 @@ The content of this document describes the parameters that can be configured in
 | `cluster.data.nodeTemplate.grpcSvc.annotations`                | Annotations for GRPC service for data pods                                      | `{}`                                         |
 | `cluster.data.nodeTemplate.grpcSvc.port`                       | Port number for GRPC service for data pods                                      | `17912`                                      |
 | `cluster.data.nodeTemplate.sidecar`                            | Sidecar containers for data pods                                                | `[]`                                         |
+| `cluster.data.nodeTemplate.backupSidecar.env`                  | Environment variables for the backup sidecar                                    | `[]`                                         |
 | `cluster.data.nodeTemplate.backupSidecar.enabled`              | Enable backup sidecar for data pods (boolean)                                   | `false`                                      |
 | `cluster.data.nodeTemplate.backupSidecar.dest`                 | Backup destination path for data pods                                           | `file:///tmp/backups/data-$(ORDINAL_NUMBER)` |
 | `cluster.data.nodeTemplate.backupSidecar.timeStyle`            | Backup time style for data pods (e.g., daily)                                   | `daily`                                      |
 | `cluster.data.nodeTemplate.backupSidecar.schedule`             | Backup schedule for data pods (cron format)                                     | `@hourly`                                    |
 | `cluster.data.nodeTemplate.backupSidecar.customFlags`          | Custom flags for backup sidecar (e.g., S3, Azure, GCS configuration)            | `[]`                                         |
 | `cluster.data.nodeTemplate.backupSidecar.resources`            | Resources for backup sidecar for data pods                                      | `{}`                                         |
+| `cluster.data.nodeTemplate.lifecycleSidecar.env`               | Environment variables for the lifecycle sidecar                                 | `[]`                                         |
 | `cluster.data.nodeTemplate.lifecycleSidecar.enabled`           | Enable lifecycle sidecar for data pods (boolean)                                | `false`                                      |
 | `cluster.data.nodeTemplate.lifecycleSidecar.schedule`          | Schedule for lifecycle sidecar (cron format)                                    | `@hourly`                                    |
 | `cluster.data.nodeTemplate.lifecycleSidecar.progressFile`      | Progress file path for lifecycle sidecar                                        | `""`                                         |
 | `cluster.data.nodeTemplate.lifecycleSidecar.reportDir`         | Report directory path for lifecycle sidecar                                     | `""`                                         |
 | `cluster.data.nodeTemplate.lifecycleSidecar.resources`         | Resources for lifecycle sidecar for data pods                                   | `{}`                                         |
+| `cluster.data.nodeTemplate.restoreInitContainer.env`           | Environment variables for the restore init container                            | `[]`                                         |
 | `cluster.data.nodeTemplate.restoreInitContainer.enabled`       | Enable restore init container for data pods (boolean)                           | `false`                                      |
 | `cluster.data.nodeTemplate.restoreInitContainer.customFlags`   | Custom flags for restore init container (e.g., S3, Azure, GCS configuration)    | `[]`                                         |
 | `cluster.data.nodeTemplate.restoreInitContainer.resources`     | Resources for restore init container for data pods                              | `{}`                                         |