You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2018/01/26 21:03:42 UTC
Review Request 65356: HIVE-18536 IOW + DP is broken for insert-only
ACID
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65356/
-----------------------------------------------------------
Review request for hive and Eugene Koifman.
Repository: hive-git
Description
-------
.
Diffs
-----
common/src/java/org/apache/hadoop/hive/common/JavaUtils.java 9f64b3d2e0
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 2e1fd37d4a
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 23983d85b3
Diff: https://reviews.apache.org/r/65356/diff/1/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 65356: HIVE-18536 IOW + DP is broken for
insert-only ACID
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65356/
-----------------------------------------------------------
(Updated Jan. 31, 2018, 12:21 a.m.)
Review request for hive and Eugene Koifman.
Repository: hive-git
Description
-------
.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/common/JavaUtils.java 9f64b3d2e0
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 7348faa9bb
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 63bcedc000
Diff: https://reviews.apache.org/r/65356/diff/3/
Changes: https://reviews.apache.org/r/65356/diff/2-3/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 65356: HIVE-18536 IOW + DP is broken for
insert-only ACID
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65356/
-----------------------------------------------------------
(Updated Jan. 30, 2018, 1:15 a.m.)
Review request for hive and Eugene Koifman.
Repository: hive-git
Description
-------
.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/common/JavaUtils.java 9f64b3d2e0
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java d7b3e4b2fd
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 23983d85b3
Diff: https://reviews.apache.org/r/65356/diff/2/
Changes: https://reviews.apache.org/r/65356/diff/1-2/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 65356: HIVE-18536 IOW + DP is broken for
insert-only ACID
Posted by Eugene Koifman <ek...@hortonworks.com>.
> On Jan. 29, 2018, 5:13 p.m., Eugene Koifman wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
> > Line 4077 (original), 4077 (patched)
> > <https://reviews.apache.org/r/65356/diff/1/?file=1946981#file1946981line4077>
> >
> > as far as I can tell every call to this method, passes null for isBaseDir. Can this be removed?
>
> Sergey Shelukhin wrote:
> Nm, it was supposed to be passed in one place where available.
i don't understand this. are you saying there is a place where non-null value is passed in?
- Eugene
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65356/#review196437
-----------------------------------------------------------
On Jan. 31, 2018, 12:21 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65356/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2018, 12:21 a.m.)
>
>
> Review request for hive and Eugene Koifman.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/common/JavaUtils.java 9f64b3d2e0
> ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 7348faa9bb
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 63bcedc000
>
>
> Diff: https://reviews.apache.org/r/65356/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 65356: HIVE-18536 IOW + DP is broken for
insert-only ACID
Posted by Sergey Shelukhin <se...@hortonworks.com>.
> On Jan. 29, 2018, 5:13 p.m., Eugene Koifman wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
> > Line 4077 (original), 4077 (patched)
> > <https://reviews.apache.org/r/65356/diff/1/?file=1946981#file1946981line4077>
> >
> > as far as I can tell every call to this method, passes null for isBaseDir. Can this be removed?
>
> Sergey Shelukhin wrote:
> Nm, it was supposed to be passed in one place where available.
>
> Eugene Koifman wrote:
> i don't understand this. are you saying there is a place where non-null value is passed in?
Yes
- Sergey
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65356/#review196437
-----------------------------------------------------------
On Jan. 31, 2018, 12:21 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65356/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2018, 12:21 a.m.)
>
>
> Review request for hive and Eugene Koifman.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/common/JavaUtils.java 9f64b3d2e0
> ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 7348faa9bb
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 63bcedc000
>
>
> Diff: https://reviews.apache.org/r/65356/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 65356: HIVE-18536 IOW + DP is broken for
insert-only ACID
Posted by Sergey Shelukhin <se...@hortonworks.com>.
> On Jan. 29, 2018, 5:13 p.m., Eugene Koifman wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
> > Line 4077 (original), 4077 (patched)
> > <https://reviews.apache.org/r/65356/diff/1/?file=1946981#file1946981line4077>
> >
> > as far as I can tell every call to this method, passes null for isBaseDir. Can this be removed?
Nm, it was supposed to be passed in one place where available.
- Sergey
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65356/#review196437
-----------------------------------------------------------
On Jan. 26, 2018, 9:03 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65356/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2018, 9:03 p.m.)
>
>
> Review request for hive and Eugene Koifman.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/common/JavaUtils.java 9f64b3d2e0
> ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 2e1fd37d4a
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 23983d85b3
>
>
> Diff: https://reviews.apache.org/r/65356/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 65356: HIVE-18536 IOW + DP is broken for
insert-only ACID
Posted by Eugene Koifman <ek...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65356/#review196437
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
Line 4077 (original), 4077 (patched)
<https://reviews.apache.org/r/65356/#comment276082>
as far as I can tell every call to this method, passes null for isBaseDir. Can this be removed?
- Eugene Koifman
On Jan. 26, 2018, 9:03 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65356/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2018, 9:03 p.m.)
>
>
> Review request for hive and Eugene Koifman.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/common/JavaUtils.java 9f64b3d2e0
> ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 2e1fd37d4a
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 23983d85b3
>
>
> Diff: https://reviews.apache.org/r/65356/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>