You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by gi...@git.apache.org on 2017/09/13 20:18:46 UTC

[GitHub] timifasubaa opened a new pull request #3459: Sqllab dont send empty queries to db

timifasubaa opened a new pull request #3459: Sqllab  dont send empty queries to db
URL: https://github.com/apache/incubator-superset/pull/3459
 
 
   Fixes: 
   https://github.com/apache/incubator-superset/issues/2102
   
   Ideally I would have liked the button to communicate that it isn't listening to queries (by turning yellow or something) but that was beginning to be unnecessarily complicated. After this change, if you type in an empty query it just doesn't send anything to the db. 
   
   @mistercrunch @ascott 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services