You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@issues.apache.org on 2010/06/09 19:03:40 UTC
[Bug 6447] New: new feature to bayes autolearning: learn-on-error
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6447
Summary: new feature to bayes autolearning: learn-on-error
Product: Spamassassin
Version: 3.3.1
Platform: All
OS/Version: All
Status: NEW
Severity: enhancement
Priority: P2
Component: Learner
AssignedTo: dev@spamassassin.apache.org
ReportedBy: Mark.Martinec@ijs.si
Here is a proposed patch to SA::Plugin::AutoLearnThreshold to implement
learn-on-error learning strategy, along with a control setting to
enable it, or to retain old behaviour (which is a default).
I have been envying the CRM114 classifier for a long time for having
this capability (which is its default and works well). Now that our
bayes database grew again to a huge size and slow operations, I decided
that it's about time to add this learning strategy to SpamAssassin too.
I took a simple approach on just testing for triggered rules - if someone
feels it should warrant some other under-the-hood approach, please suggest it.
The docs should be able to explain the new setting and learning strategy:
bayes_auto_learn_on_error (0 | 1) (default: 0)
With C<bayes_auto_learn_on_error> off, autolearning will be performed
even if bayes classifier already agrees with the new classification (i.e.
yielded BAYES_00 for what we are now trying to teach it as ham, or yielded
BAYES_99 for spam). This is a traditional setting, the default was chosen
to retain backwards compatibility.
With C<bayes_auto_learn_on_error> turned on, autolearning will be performed
only when a bayes classifier had a different opinion from what the autolearner
is now trying to teach it (i.e. it made an error in judgement). This strategy
may or may not produce better future classifications, but usually works
very well, while also preventing unnecessary overlearning and slows down
database growth.
There is also a 'feature' subroutine which can be queried for the capability:
local.cf:
if can(Mail::SpamAssassin::Conf::feature_bayes_auto_learn_on_error)
bayes_auto_learn_on_error 1
endif
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6447] new feature to bayes autolearning: learn-on-error
Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6447
--- Comment #1 from Mark Martinec <Ma...@ijs.si> 2010-06-09 13:07:17 EDT ---
Created an attachment (id=4772)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4772)
proposed patch
trunk:
Bug 6447: new feature to bayes autolearning: learn-on-error
Sending lib/Mail/SpamAssassin/Conf.pm
Sending lib/Mail/SpamAssassin/Plugin/AutoLearnThreshold.pm
Committed revision 953082.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6447] [review] new feature to bayes autolearning:
learn-on-error
Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6447
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P4 |P3
Target Milestone|3.4.0 |3.3.2
Summary|new feature to bayes |[review] new feature to
|autolearning: |bayes autolearning:
|learn-on-error |learn-on-error
Status Whiteboard| |needs 1 vote for 3.3.2
--- Comment #4 from Mark Martinec <Ma...@ijs.si> 2010-06-11 18:46:20 EDT ---
Ok, let's see if this can make it into 3.3.2 - retargeting.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6447] [review] new feature to bayes autolearning:
learn-on-error
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6447
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #6 from Mark Martinec <Ma...@ijs.si> 2011-05-09 00:46:47 UTC ---
3.3:
Bug 6447: new feature to bayes autolearning: learn-on-error
Sending lib/Mail/SpamAssassin/Conf.pm
Sending lib/Mail/SpamAssassin/Plugin/AutoLearnThreshold.pm
Committed revision 1100854.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6447] new feature to bayes autolearning: learn-on-error
Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6447
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P2 |P4
Target Milestone|Undefined |3.4.0
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6447] [review] new feature to bayes autolearning:
learn-on-error
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6447
Henrik Krohns <he...@hege.li> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hege@hege.li
Status Whiteboard|needs 1 vote for 3.3.2 |ready to commit for 3.3.2
--- Comment #5 from Henrik Krohns <he...@hege.li> 2011-05-08 18:54:52 UTC ---
+1 looks great
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6447] new feature to bayes autolearning: learn-on-error
Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6447
--- Comment #2 from Mark Martinec <Ma...@ijs.si> 2010-06-10 13:31:08 EDT ---
As this is a fairly small / straightforward / self-contained change
with good returns, please speak up if someone thinks it should be
re-targeted for 3.3.2.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6447] new feature to bayes autolearning: learn-on-error
Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6447
Kevin A. McGrail <km...@pccc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kmcgrail@pccc.com
--- Comment #3 from Kevin A. McGrail <km...@pccc.com> 2010-06-10 14:05:50 EDT ---
+1 KAM
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.