You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2016/04/20 12:05:31 UTC
Review Request 46430: LENS-730 : Fix alias issues with multifact
queries
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46430/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-730
https://issues.apache.org/jira/browse/LENS-730
Repository: lens
Description
-------
Fixes following alias issues with multi fact queries and expressions
- When alias of a selected expression is a column name used in a Expression column. For ex : select col1 as f1, expr1 as f2 from cube ; expr1 = complex(f2)
- When different expressions (functions) are around a column and no alias is passed for them : For : func1(dim1), func2(dim1)
- When alias is in the form of expression. For ex: select msr1 as `sum(msr1)` from cube
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java fd7036a
lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 75aa3f4
lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 04c3c45
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 379e873
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java fec5d51
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBridgeTableQueries.java e8905c1
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 6ee45d8
lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java fa07b67
Diff: https://reviews.apache.org/r/46430/diff/
Testing
-------
All cube tests pass.
Thanks,
Amareshwari Sriramadasu
Re: Review Request 46430: LENS-730 : Fix alias issues with multifact
queries
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On April 20, 2016, 10:14 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java, lines 485-486
> > <https://reviews.apache.org/r/46430/diff/1/?file=1353062#file1353062line485>
> >
> > Should the outer alias be `func1(dim1)` and `func2(dim1)` instead of `expr1` and `expr2`?
Didnt want to make any such - as we are not sure all drivers might support such aliases. Let user give is he want any alias. If not given, we are giving alias with index of the selection.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46430/#review129718
-----------------------------------------------------------
On April 20, 2016, 10:05 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46430/
> -----------------------------------------------------------
>
> (Updated April 20, 2016, 10:05 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-730
> https://issues.apache.org/jira/browse/LENS-730
>
>
> Repository: lens
>
>
> Description
> -------
>
> Fixes following alias issues with multi fact queries and expressions
>
> - When alias of a selected expression is a column name used in a Expression column. For ex : select col1 as f1, expr1 as f2 from cube ; expr1 = complex(f2)
> - When different expressions (functions) are around a column and no alias is passed for them : For : func1(dim1), func2(dim1)
> - When alias is in the form of expression. For ex: select msr1 as `sum(msr1)` from cube
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java fd7036a
> lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 75aa3f4
> lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 04c3c45
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 379e873
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java fec5d51
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBridgeTableQueries.java e8905c1
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 6ee45d8
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java fa07b67
>
> Diff: https://reviews.apache.org/r/46430/diff/
>
>
> Testing
> -------
>
> All cube tests pass.
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 46430: LENS-730 : Fix alias issues with multifact
queries
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On April 20, 2016, 3:44 p.m., Rajat Khandelwal wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java, lines 485-486
> > <https://reviews.apache.org/r/46430/diff/1/?file=1353062#file1353062line485>
> >
> > Should the outer alias be `func1(dim1)` and `func2(dim1)` instead of `expr1` and `expr2`?
>
> Amareshwari Sriramadasu wrote:
> Didnt want to make any such - as we are not sure all drivers might support such aliases. Let user give is he want any alias. If not given, we are giving alias with index of the selection.
Yes, but in the final report headings like `expr1`, `expr2` might be confusing.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46430/#review129718
-----------------------------------------------------------
On April 20, 2016, 6:15 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46430/
> -----------------------------------------------------------
>
> (Updated April 20, 2016, 6:15 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-730
> https://issues.apache.org/jira/browse/LENS-730
>
>
> Repository: lens
>
>
> Description
> -------
>
> Fixes following alias issues with multi fact queries and expressions
>
> - When alias of a selected expression is a column name used in a Expression column. For ex : select col1 as f1, expr1 as f2 from cube ; expr1 = complex(f2)
> - When different expressions (functions) are around a column and no alias is passed for them : For : func1(dim1), func2(dim1)
> - When alias is in the form of expression. For ex: select msr1 as `sum(msr1)` from cube
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java fd7036a
> lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 75aa3f4
> lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 04c3c45
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 379e873
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java fec5d51
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBridgeTableQueries.java e8905c1
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 6ee45d8
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java fa07b67
>
> Diff: https://reviews.apache.org/r/46430/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.014s]
> [INFO] Lens .............................................. SUCCESS [5.016s]
> [INFO] Lens API .......................................... SUCCESS [23.090s]
> [INFO] Lens API for server and extensions ................ SUCCESS [15.016s]
> [INFO] Lens Cube ......................................... SUCCESS [20:25.912s]
> [INFO] Lens DB storage ................................... SUCCESS [15.127s]
> [INFO] Lens Query Library ................................ SUCCESS [11.787s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:26.720s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [29.037s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [13.003s]
> [INFO] Lens Server ....................................... SUCCESS [14:24.102s]
> [INFO] Lens client ....................................... SUCCESS [32.295s]
> [INFO] Lens CLI .......................................... SUCCESS [2:56.034s]
> [INFO] Lens Examples ..................................... SUCCESS [9.271s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.792s]
> [INFO] Lens Distribution ................................. SUCCESS [8.750s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:06.477s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.038s]
> [INFO] Lens Regression ................................... SUCCESS [9.772s]
> [INFO] Lens UI ........................................... SUCCESS [42.532s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 44:59.552s
> [INFO] Finished at: Wed Apr 20 10:43:22 UTC 2016
> [INFO] Final Memory: 187M/2713M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 46430: LENS-730 : Fix alias issues with multifact
queries
Posted by Sushil Mohanty <su...@gmail.com>.
> On April 20, 2016, 10:14 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java, lines 485-486
> > <https://reviews.apache.org/r/46430/diff/1/?file=1353062#file1353062line485>
> >
> > Should the outer alias be `func1(dim1)` and `func2(dim1)` instead of `expr1` and `expr2`?
>
> Amareshwari Sriramadasu wrote:
> Didnt want to make any such - as we are not sure all drivers might support such aliases. Let user give is he want any alias. If not given, we are giving alias with index of the selection.
>
> Rajat Khandelwal wrote:
> Yes, but in the final report headings like `expr1`, `expr2` might be confusing.
>
> Amareshwari Sriramadasu wrote:
> Should we remove final aliases from multi fact query if no alias is passed?
IMO, it makes sense. If user didn't specify any alias for projected column or expression, by default the same should appear in heading.
- Sushil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46430/#review129718
-----------------------------------------------------------
On April 20, 2016, 12:45 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46430/
> -----------------------------------------------------------
>
> (Updated April 20, 2016, 12:45 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-730
> https://issues.apache.org/jira/browse/LENS-730
>
>
> Repository: lens
>
>
> Description
> -------
>
> Fixes following alias issues with multi fact queries and expressions
>
> - When alias of a selected expression is a column name used in a Expression column. For ex : select col1 as f1, expr1 as f2 from cube ; expr1 = complex(f2)
> - When different expressions (functions) are around a column and no alias is passed for them : For : func1(dim1), func2(dim1)
> - When alias is in the form of expression. For ex: select msr1 as `sum(msr1)` from cube
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java fd7036a
> lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 75aa3f4
> lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 04c3c45
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 379e873
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java fec5d51
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBridgeTableQueries.java e8905c1
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 6ee45d8
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java fa07b67
>
> Diff: https://reviews.apache.org/r/46430/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.014s]
> [INFO] Lens .............................................. SUCCESS [5.016s]
> [INFO] Lens API .......................................... SUCCESS [23.090s]
> [INFO] Lens API for server and extensions ................ SUCCESS [15.016s]
> [INFO] Lens Cube ......................................... SUCCESS [20:25.912s]
> [INFO] Lens DB storage ................................... SUCCESS [15.127s]
> [INFO] Lens Query Library ................................ SUCCESS [11.787s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:26.720s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [29.037s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [13.003s]
> [INFO] Lens Server ....................................... SUCCESS [14:24.102s]
> [INFO] Lens client ....................................... SUCCESS [32.295s]
> [INFO] Lens CLI .......................................... SUCCESS [2:56.034s]
> [INFO] Lens Examples ..................................... SUCCESS [9.271s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.792s]
> [INFO] Lens Distribution ................................. SUCCESS [8.750s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:06.477s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.038s]
> [INFO] Lens Regression ................................... SUCCESS [9.772s]
> [INFO] Lens UI ........................................... SUCCESS [42.532s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 44:59.552s
> [INFO] Finished at: Wed Apr 20 10:43:22 UTC 2016
> [INFO] Final Memory: 187M/2713M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 46430: LENS-730 : Fix alias issues with multifact
queries
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On April 20, 2016, 10:14 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java, lines 485-486
> > <https://reviews.apache.org/r/46430/diff/1/?file=1353062#file1353062line485>
> >
> > Should the outer alias be `func1(dim1)` and `func2(dim1)` instead of `expr1` and `expr2`?
>
> Amareshwari Sriramadasu wrote:
> Didnt want to make any such - as we are not sure all drivers might support such aliases. Let user give is he want any alias. If not given, we are giving alias with index of the selection.
>
> Rajat Khandelwal wrote:
> Yes, but in the final report headings like `expr1`, `expr2` might be confusing.
Should we remove final aliases from multi fact query if no alias is passed?
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46430/#review129718
-----------------------------------------------------------
On April 20, 2016, 12:45 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46430/
> -----------------------------------------------------------
>
> (Updated April 20, 2016, 12:45 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-730
> https://issues.apache.org/jira/browse/LENS-730
>
>
> Repository: lens
>
>
> Description
> -------
>
> Fixes following alias issues with multi fact queries and expressions
>
> - When alias of a selected expression is a column name used in a Expression column. For ex : select col1 as f1, expr1 as f2 from cube ; expr1 = complex(f2)
> - When different expressions (functions) are around a column and no alias is passed for them : For : func1(dim1), func2(dim1)
> - When alias is in the form of expression. For ex: select msr1 as `sum(msr1)` from cube
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java fd7036a
> lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 75aa3f4
> lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 04c3c45
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 379e873
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java fec5d51
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBridgeTableQueries.java e8905c1
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 6ee45d8
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java fa07b67
>
> Diff: https://reviews.apache.org/r/46430/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.014s]
> [INFO] Lens .............................................. SUCCESS [5.016s]
> [INFO] Lens API .......................................... SUCCESS [23.090s]
> [INFO] Lens API for server and extensions ................ SUCCESS [15.016s]
> [INFO] Lens Cube ......................................... SUCCESS [20:25.912s]
> [INFO] Lens DB storage ................................... SUCCESS [15.127s]
> [INFO] Lens Query Library ................................ SUCCESS [11.787s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:26.720s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [29.037s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [13.003s]
> [INFO] Lens Server ....................................... SUCCESS [14:24.102s]
> [INFO] Lens client ....................................... SUCCESS [32.295s]
> [INFO] Lens CLI .......................................... SUCCESS [2:56.034s]
> [INFO] Lens Examples ..................................... SUCCESS [9.271s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.792s]
> [INFO] Lens Distribution ................................. SUCCESS [8.750s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:06.477s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.038s]
> [INFO] Lens Regression ................................... SUCCESS [9.772s]
> [INFO] Lens UI ........................................... SUCCESS [42.532s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 44:59.552s
> [INFO] Finished at: Wed Apr 20 10:43:22 UTC 2016
> [INFO] Final Memory: 187M/2713M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 46430: LENS-730 : Fix alias issues with multifact
queries
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46430/#review129718
-----------------------------------------------------------
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java (lines 485 - 486)
<https://reviews.apache.org/r/46430/#comment193268>
Should the outer alias be `func1(dim1)` and `func2(dim1)` instead of `expr1` and `expr2`?
- Rajat Khandelwal
On April 20, 2016, 3:35 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46430/
> -----------------------------------------------------------
>
> (Updated April 20, 2016, 3:35 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-730
> https://issues.apache.org/jira/browse/LENS-730
>
>
> Repository: lens
>
>
> Description
> -------
>
> Fixes following alias issues with multi fact queries and expressions
>
> - When alias of a selected expression is a column name used in a Expression column. For ex : select col1 as f1, expr1 as f2 from cube ; expr1 = complex(f2)
> - When different expressions (functions) are around a column and no alias is passed for them : For : func1(dim1), func2(dim1)
> - When alias is in the form of expression. For ex: select msr1 as `sum(msr1)` from cube
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java fd7036a
> lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 75aa3f4
> lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 04c3c45
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 379e873
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java fec5d51
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBridgeTableQueries.java e8905c1
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 6ee45d8
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java fa07b67
>
> Diff: https://reviews.apache.org/r/46430/diff/
>
>
> Testing
> -------
>
> All cube tests pass.
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 46430: LENS-730 : Fix alias issues with multifact
queries
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46430/#review130594
-----------------------------------------------------------
Ship it!
Ship It!
- Rajat Khandelwal
On April 22, 2016, 4:41 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46430/
> -----------------------------------------------------------
>
> (Updated April 22, 2016, 4:41 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-730
> https://issues.apache.org/jira/browse/LENS-730
>
>
> Repository: lens
>
>
> Description
> -------
>
> Fixes following alias issues with multi fact queries and expressions
>
> - When alias of a selected expression is a column name used in a Expression column. For ex : select col1 as f1, expr1 as f2 from cube ; expr1 = complex(f2)
> - When different expressions (functions) are around a column and no alias is passed for them : For : func1(dim1), func2(dim1)
> - When alias is in the form of expression. For ex: select msr1 as `sum(msr1)` from cube
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java fd7036a
> lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 75aa3f4
> lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 04c3c45
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 379e873
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java fec5d51
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBridgeTableQueries.java e8905c1
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 6ee45d8
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java fa07b67
>
> Diff: https://reviews.apache.org/r/46430/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.014s]
> [INFO] Lens .............................................. SUCCESS [5.016s]
> [INFO] Lens API .......................................... SUCCESS [23.090s]
> [INFO] Lens API for server and extensions ................ SUCCESS [15.016s]
> [INFO] Lens Cube ......................................... SUCCESS [20:25.912s]
> [INFO] Lens DB storage ................................... SUCCESS [15.127s]
> [INFO] Lens Query Library ................................ SUCCESS [11.787s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:26.720s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [29.037s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [13.003s]
> [INFO] Lens Server ....................................... SUCCESS [14:24.102s]
> [INFO] Lens client ....................................... SUCCESS [32.295s]
> [INFO] Lens CLI .......................................... SUCCESS [2:56.034s]
> [INFO] Lens Examples ..................................... SUCCESS [9.271s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.792s]
> [INFO] Lens Distribution ................................. SUCCESS [8.750s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:06.477s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.038s]
> [INFO] Lens Regression ................................... SUCCESS [9.772s]
> [INFO] Lens UI ........................................... SUCCESS [42.532s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 44:59.552s
> [INFO] Finished at: Wed Apr 20 10:43:22 UTC 2016
> [INFO] Final Memory: 187M/2713M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 46430: LENS-730 : Fix alias issues with multifact
queries
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46430/
-----------------------------------------------------------
(Updated April 22, 2016, 11:11 a.m.)
Review request for lens.
Changes
-------
Updated review comments
Bugs: LENS-730
https://issues.apache.org/jira/browse/LENS-730
Repository: lens
Description
-------
Fixes following alias issues with multi fact queries and expressions
- When alias of a selected expression is a column name used in a Expression column. For ex : select col1 as f1, expr1 as f2 from cube ; expr1 = complex(f2)
- When different expressions (functions) are around a column and no alias is passed for them : For : func1(dim1), func2(dim1)
- When alias is in the form of expression. For ex: select msr1 as `sum(msr1)` from cube
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java fd7036a
lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 75aa3f4
lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 04c3c45
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 379e873
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java fec5d51
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBridgeTableQueries.java e8905c1
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 6ee45d8
lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java fa07b67
Diff: https://reviews.apache.org/r/46430/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.014s]
[INFO] Lens .............................................. SUCCESS [5.016s]
[INFO] Lens API .......................................... SUCCESS [23.090s]
[INFO] Lens API for server and extensions ................ SUCCESS [15.016s]
[INFO] Lens Cube ......................................... SUCCESS [20:25.912s]
[INFO] Lens DB storage ................................... SUCCESS [15.127s]
[INFO] Lens Query Library ................................ SUCCESS [11.787s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:26.720s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [29.037s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [13.003s]
[INFO] Lens Server ....................................... SUCCESS [14:24.102s]
[INFO] Lens client ....................................... SUCCESS [32.295s]
[INFO] Lens CLI .......................................... SUCCESS [2:56.034s]
[INFO] Lens Examples ..................................... SUCCESS [9.271s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.792s]
[INFO] Lens Distribution ................................. SUCCESS [8.750s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:06.477s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.038s]
[INFO] Lens Regression ................................... SUCCESS [9.772s]
[INFO] Lens UI ........................................... SUCCESS [42.532s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 44:59.552s
[INFO] Finished at: Wed Apr 20 10:43:22 UTC 2016
[INFO] Final Memory: 187M/2713M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 46430: LENS-730 : Fix alias issues with multifact
queries
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46430/
-----------------------------------------------------------
(Updated April 20, 2016, 12:45 p.m.)
Review request for lens.
Bugs: LENS-730
https://issues.apache.org/jira/browse/LENS-730
Repository: lens
Description
-------
Fixes following alias issues with multi fact queries and expressions
- When alias of a selected expression is a column name used in a Expression column. For ex : select col1 as f1, expr1 as f2 from cube ; expr1 = complex(f2)
- When different expressions (functions) are around a column and no alias is passed for them : For : func1(dim1), func2(dim1)
- When alias is in the form of expression. For ex: select msr1 as `sum(msr1)` from cube
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java fd7036a
lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 75aa3f4
lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 04c3c45
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 379e873
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java fec5d51
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBridgeTableQueries.java e8905c1
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 6ee45d8
lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java fa07b67
Diff: https://reviews.apache.org/r/46430/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.014s]
[INFO] Lens .............................................. SUCCESS [5.016s]
[INFO] Lens API .......................................... SUCCESS [23.090s]
[INFO] Lens API for server and extensions ................ SUCCESS [15.016s]
[INFO] Lens Cube ......................................... SUCCESS [20:25.912s]
[INFO] Lens DB storage ................................... SUCCESS [15.127s]
[INFO] Lens Query Library ................................ SUCCESS [11.787s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:26.720s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [29.037s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [13.003s]
[INFO] Lens Server ....................................... SUCCESS [14:24.102s]
[INFO] Lens client ....................................... SUCCESS [32.295s]
[INFO] Lens CLI .......................................... SUCCESS [2:56.034s]
[INFO] Lens Examples ..................................... SUCCESS [9.271s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.792s]
[INFO] Lens Distribution ................................. SUCCESS [8.750s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:06.477s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.038s]
[INFO] Lens Regression ................................... SUCCESS [9.772s]
[INFO] Lens UI ........................................... SUCCESS [42.532s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 44:59.552s
[INFO] Finished at: Wed Apr 20 10:43:22 UTC 2016
[INFO] Final Memory: 187M/2713M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu