You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2016/12/27 13:38:29 UTC

svn commit: r1776129 - /jmeter/trunk/src/core/org/apache/jmeter/util/BSFJavaScriptEngine.java

Author: pmouawad
Date: Tue Dec 27 13:38:28 2016
New Revision: 1776129

URL: http://svn.apache.org/viewvc?rev=1776129&view=rev
Log:
Sonar : Fix errors, vulnerabilities

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/util/BSFJavaScriptEngine.java

Modified: jmeter/trunk/src/core/org/apache/jmeter/util/BSFJavaScriptEngine.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/util/BSFJavaScriptEngine.java?rev=1776129&r1=1776128&r2=1776129&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/util/BSFJavaScriptEngine.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/util/BSFJavaScriptEngine.java Tue Dec 27 13:38:28 2016
@@ -87,15 +87,12 @@ public class BSFJavaScriptEngine extends
 
             retval =
                 ((Function) fun).call(cx, global, global, args);
-
-//                ScriptRuntime.call(cx, fun, global, args, global);
-
             if (retval instanceof Wrapper) {
                 retval = ((Wrapper) retval).unwrap();
             }
         }
         catch (Throwable t) {
-            handleError(t);
+            handleError(t); //NOSONAR We handle correctly Error case in function
         }
         finally {
             Context.exit();
@@ -149,7 +146,7 @@ public class BSFJavaScriptEngine extends
 
         }
         catch (Throwable t) { // includes JavaScriptException, rethrows Errors
-            handleError(t);
+            handleError(t); // NOSONAR We handle correctly Error case in function
         }
         finally {
             Context.exit();
@@ -231,7 +228,7 @@ public class BSFJavaScriptEngine extends
             }
         }
         catch (Throwable t) {
-            handleError(t);
+            handleError(t); // NOSONAR We handle correctly Error case in function
         }
         finally {
             Context.exit();