You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/05/02 17:50:00 UTC
[jira] [Commented] (CB-14013) cordova-plugin-inappbrowser support
for custom URL schemes, as needed for oAuth
[ https://issues.apache.org/jira/browse/CB-14013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461392#comment-16461392 ]
ASF GitHub Bot commented on CB-14013:
-------------------------------------
timbru31 commented on issue #263: CB-14013: (android) Change the InAppBrowser to allow custom schemes for oAuth
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/263#issuecomment-386063556
@SailingSteve possible to add support for staging+mycoolapp? Currently the plus sign is excluded from your regexp (`^[a-z]*://.*?$`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> cordova-plugin-inappbrowser support for custom URL schemes, as needed for oAuth
> -------------------------------------------------------------------------------
>
> Key: CB-14013
> URL: https://issues.apache.org/jira/browse/CB-14013
> Project: Apache Cordova
> Issue Type: New Feature
> Components: cordova-plugin-inappbrowser
> Affects Versions: cordova@7.0.0
> Reporter: Steve Podell
> Priority: Major
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> A very common usage of the inappbrowser is to open a URL to the apps server, as part of the oAuth flow. After a secure token is created, the final step in the oAuth flow is to redirect back to the Cordova app, to proceed as authenticated. At the WeVote open source project we use this to authenticate with Twitter and Facebook, other projects want to authenticate with Google, Whatsapp, Skype, etc.
> There is a package for React Native react-native-oauth that does this, and I was able to get oAuth working for iOS with cordova-plugin-safariviewcontroller, but there is nothing that is stable, maintained, and working that is equivalent for Android.
> A pull request will follow that uses whitelisted schemes to allow the oAuth redirect to complete through the InAppBrowser. It is a fairly simple code change, that leads to a simple end user implementation, that should be widely appreciated (based on years of mostly unfulfilled Stack Overflow chatter.)
>
> This PR builds on [https://github.com/apache/cordova-plugin-inappbrowser/pull/99] and [https://github.com/apache/cordova-plugin-inappbrowser/pull/261] and builds on a good suggestion from *[NGumby|https://github.com/NGumby]* and comments about viability from *[infil00p|https://github.com/infil00p]*
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org