You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/11/04 03:18:01 UTC
[GitHub] [skywalking] kezhenxu94 opened a new pull request, #9904: Refactor storage implementations to reuse logics
kezhenxu94 opened a new pull request, #9904:
URL: https://github.com/apache/skywalking/pull/9904
<!--
â ī¸ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== đ Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist đ ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== đ Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist đ ==== -->
<!-- ==== đ Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist đ ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== đ Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist đ ==== -->
<!-- ==== đ Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist đ ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== đ Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist đ ==== -->
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 merged pull request #9904: Refactor jdbc storage implementations to reuse logics
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged PR #9904:
URL: https://github.com/apache/skywalking/pull/9904
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9904: Refactor jdbc storage implementations to reuse logics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #9904:
URL: https://github.com/apache/skywalking/pull/9904#discussion_r1014954766
##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/model/ModelInstaller.java:
##########
@@ -58,6 +57,9 @@ public void whenCreating(Model model) throws StorageException {
}
}
+ public void start() {
Review Comment:
What does `ModelInstaller#start` mean?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on pull request #9904: Refactor jdbc storage implementations to reuse logics
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on PR #9904:
URL: https://github.com/apache/skywalking/pull/9904#issuecomment-1304976023
A brief change list:
- Rename all general `H2XXXX` to `JDBCXXXX` and move them to `jdbc/common` package for general uses of JDBC-compatible storages.
- Unify the configurations of JDBC storages by adding `JDBCStorageConfig`, if specific storage needs new configurations, they can extend `JDBCStorageConfig`, example like `MySQLShardingStorageConfig`.
- Remove mounting config files in `test/e2e-v2/script/shardingsphere-proxy/base-compose.yml`, this is general base docker-compose.yaml and the config files should be mounted in where it's used, like when testing mysql we should mount mysql config files in the mysql case folder, and mount postgresql config files in postgresql folder.
- Remove configuratioin `h2.driver: ${SW_STORAGE_H2_DRIVER:org.h2.jdbcx.JdbcDataSource}`, this is not needed as the driver name can be inferred from the URL `jdbc:h2`, also use the same `properties` configuration style as other JDBC storages used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a diff in pull request #9904: Refactor jdbc storage implementations to reuse logics
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on code in PR #9904:
URL: https://github.com/apache/skywalking/pull/9904#discussion_r1014957314
##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/model/ModelInstaller.java:
##########
@@ -58,6 +57,9 @@ public void whenCreating(Model model) throws StorageException {
}
}
+ public void start() {
Review Comment:
> What does `ModelInstaller#start` mean?
This is to provide a hook for child-implementations of model installer to do initializations, for now, we do column overrides (e.g. `overrideColumnName("value", "value_");`) in this method.
Previously we do `overrideColumnName("value", "value_");` in the constructor of model installer, this is not an appropriate phase because `overrideColumnName("value", "value_");` requires services that must be already registered to module manager and it might raise `Still in preparing stage` exception if the construction of model installer is too early.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a diff in pull request #9904: Refactor jdbc storage implementations to reuse logics
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on code in PR #9904:
URL: https://github.com/apache/skywalking/pull/9904#discussion_r1015051253
##########
oap-server/server-storage-plugin/storage-shardingsphere-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/shardingsphere/ShardingSphereTableInstaller.java:
##########
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.storage.plugin.jdbc.shardingsphere;
+
+import java.sql.Connection;
+import java.util.List;
+import java.util.Set;
+import org.apache.skywalking.oap.server.core.CoreModule;
+import org.apache.skywalking.oap.server.core.config.ConfigService;
+import org.apache.skywalking.oap.server.core.storage.StorageException;
+import org.apache.skywalking.oap.server.core.storage.model.Model;
+import org.apache.skywalking.oap.server.core.storage.model.ModelColumn;
+import org.apache.skywalking.oap.server.library.client.Client;
+import org.apache.skywalking.oap.server.library.client.jdbc.JDBCClientException;
+import org.apache.skywalking.oap.server.library.client.jdbc.hikaricp.JDBCHikariCPClient;
+import org.apache.skywalking.oap.server.library.module.ModuleManager;
+import org.apache.skywalking.oap.server.storage.plugin.jdbc.h2.H2TableInstaller;
+
+/**
+ * ShardingSphere table installer delegates all the works to
+ * the table installer (e.g. H2TableInstaller, MySQLTableInstaller)
+ * of the backed storage (e.g. H2, MySQL), and then add sharding rules.
+ */
+public class ShardingSphereTableInstaller extends H2TableInstaller {
+ private final H2TableInstaller delegatee;
+ private final Set<String> dataSources;
+ private final ModuleManager moduleManager;
+
+ public ShardingSphereTableInstaller(Client client,
+ ModuleManager moduleManager,
+ Set<String> dataSources,
+ H2TableInstaller delegatee) {
+ super(client, moduleManager);
+ this.dataSources = dataSources;
+ this.delegatee = delegatee;
+ this.moduleManager = moduleManager;
+ }
+
+ @Override
+ public boolean isExists(Model model) throws StorageException {
+ boolean isRuleExecuted = false;
+ boolean isTableExist = delegatee.isExists(model);
+ JDBCHikariCPClient jdbcClient = (JDBCHikariCPClient) client;
+ ConfigService configService = moduleManager.find(CoreModule.NAME).provider().getService(ConfigService.class);
+ int ttl = model.isRecord() ? configService.getRecordDataTTL() : configService.getMetricsDataTTL();
+ if (model.getSqlDBModelExtension().isShardingTable()) {
+ isRuleExecuted = ShardingRulesOperator.INSTANCE.createOrUpdateShardingRule(jdbcClient, model, this.dataSources, ttl);
+ }
+ return isTableExist && !isRuleExecuted;
+ }
+
+ @Override
+ public void start() {
+ delegatee.start();
+ }
+
+ @Override
+ public void createTable(
+ JDBCHikariCPClient client,
+ Connection connection,
+ String tableName,
+ List<ModelColumn> columns,
+ boolean additionalTable) throws JDBCClientException {
+ delegatee.createTable(client, connection, tableName, columns, additionalTable);
+ }
+
+ @Override
+ public void createTableIndexes(
+ JDBCHikariCPClient client,
+ Connection connection,
+ String tableName,
+ List<ModelColumn> columns,
+ boolean additionalTable) throws JDBCClientException {
+ delegatee.createTable(client, connection, tableName, columns, additionalTable);
Review Comment:
This is what I changed:
1. We previously create table and then create table indices separately for MySQL storage, and
2. use create table with indices (`create table xxx (yyy int, index key0...)`), for MySQL ShardingSphere storage.
The method (2) applies to both MySQL and ShardingSphere, but method (1) only applies to MySQL storage, to unify the two implementations, I changed (1) to (2) as well so we don't need different table installer for these two implementations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wankai123 commented on a diff in pull request #9904: Refactor jdbc storage implementations to reuse logics
Posted by GitBox <gi...@apache.org>.
wankai123 commented on code in PR #9904:
URL: https://github.com/apache/skywalking/pull/9904#discussion_r1014958344
##########
oap-server/server-storage-plugin/storage-shardingsphere-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/shardingsphere/ShardingSphereTableInstaller.java:
##########
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.storage.plugin.jdbc.shardingsphere;
+
+import java.sql.Connection;
+import java.util.List;
+import java.util.Set;
+import org.apache.skywalking.oap.server.core.CoreModule;
+import org.apache.skywalking.oap.server.core.config.ConfigService;
+import org.apache.skywalking.oap.server.core.storage.StorageException;
+import org.apache.skywalking.oap.server.core.storage.model.Model;
+import org.apache.skywalking.oap.server.core.storage.model.ModelColumn;
+import org.apache.skywalking.oap.server.library.client.Client;
+import org.apache.skywalking.oap.server.library.client.jdbc.JDBCClientException;
+import org.apache.skywalking.oap.server.library.client.jdbc.hikaricp.JDBCHikariCPClient;
+import org.apache.skywalking.oap.server.library.module.ModuleManager;
+import org.apache.skywalking.oap.server.storage.plugin.jdbc.h2.H2TableInstaller;
+
+/**
+ * ShardingSphere table installer delegates all the works to
+ * the table installer (e.g. H2TableInstaller, MySQLTableInstaller)
+ * of the backed storage (e.g. H2, MySQL), and then add sharding rules.
+ */
+public class ShardingSphereTableInstaller extends H2TableInstaller {
+ private final H2TableInstaller delegatee;
+ private final Set<String> dataSources;
+ private final ModuleManager moduleManager;
+
+ public ShardingSphereTableInstaller(Client client,
+ ModuleManager moduleManager,
+ Set<String> dataSources,
+ H2TableInstaller delegatee) {
+ super(client, moduleManager);
+ this.dataSources = dataSources;
+ this.delegatee = delegatee;
+ this.moduleManager = moduleManager;
+ }
+
+ @Override
+ public boolean isExists(Model model) throws StorageException {
+ boolean isRuleExecuted = false;
+ boolean isTableExist = delegatee.isExists(model);
+ JDBCHikariCPClient jdbcClient = (JDBCHikariCPClient) client;
+ ConfigService configService = moduleManager.find(CoreModule.NAME).provider().getService(ConfigService.class);
+ int ttl = model.isRecord() ? configService.getRecordDataTTL() : configService.getMetricsDataTTL();
+ if (model.getSqlDBModelExtension().isShardingTable()) {
+ isRuleExecuted = ShardingRulesOperator.INSTANCE.createOrUpdateShardingRule(jdbcClient, model, this.dataSources, ttl);
+ }
+ return isTableExist && !isRuleExecuted;
+ }
+
+ @Override
+ public void start() {
+ delegatee.start();
+ }
+
+ @Override
+ public void createTable(
+ JDBCHikariCPClient client,
+ Connection connection,
+ String tableName,
+ List<ModelColumn> columns,
+ boolean additionalTable) throws JDBCClientException {
+ delegatee.createTable(client, connection, tableName, columns, additionalTable);
+ }
+
+ @Override
+ public void createTableIndexes(
+ JDBCHikariCPClient client,
+ Connection connection,
+ String tableName,
+ List<ModelColumn> columns,
+ boolean additionalTable) throws JDBCClientException {
+ delegatee.createTable(client, connection, tableName, columns, additionalTable);
Review Comment:
Should invoke `createTableIndexes`?
If you want to reuse the super method, should better test the index creation by using the `sharding-proxy`,
when I try to reuse it before, I got many issues, such as the index name overlength, and can not create index success in this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9904: Refactor jdbc storage implementations to reuse logics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #9904:
URL: https://github.com/apache/skywalking/pull/9904#discussion_r1014965048
##########
oap-server/server-storage-plugin/storage-shardingsphere-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/shardingsphere/ShardingSphereTableInstaller.java:
##########
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.storage.plugin.jdbc.shardingsphere;
+
+import java.sql.Connection;
+import java.util.List;
+import java.util.Set;
+import org.apache.skywalking.oap.server.core.CoreModule;
+import org.apache.skywalking.oap.server.core.config.ConfigService;
+import org.apache.skywalking.oap.server.core.storage.StorageException;
+import org.apache.skywalking.oap.server.core.storage.model.Model;
+import org.apache.skywalking.oap.server.core.storage.model.ModelColumn;
+import org.apache.skywalking.oap.server.library.client.Client;
+import org.apache.skywalking.oap.server.library.client.jdbc.JDBCClientException;
+import org.apache.skywalking.oap.server.library.client.jdbc.hikaricp.JDBCHikariCPClient;
+import org.apache.skywalking.oap.server.library.module.ModuleManager;
+import org.apache.skywalking.oap.server.storage.plugin.jdbc.h2.H2TableInstaller;
+
+/**
+ * ShardingSphere table installer delegates all the works to
+ * the table installer (e.g. H2TableInstaller, MySQLTableInstaller)
+ * of the backed storage (e.g. H2, MySQL), and then add sharding rules.
+ */
+public class ShardingSphereTableInstaller extends H2TableInstaller {
+ private final H2TableInstaller delegatee;
+ private final Set<String> dataSources;
+ private final ModuleManager moduleManager;
+
+ public ShardingSphereTableInstaller(Client client,
+ ModuleManager moduleManager,
+ Set<String> dataSources,
+ H2TableInstaller delegatee) {
+ super(client, moduleManager);
+ this.dataSources = dataSources;
+ this.delegatee = delegatee;
+ this.moduleManager = moduleManager;
+ }
+
+ @Override
+ public boolean isExists(Model model) throws StorageException {
+ boolean isRuleExecuted = false;
+ boolean isTableExist = delegatee.isExists(model);
+ JDBCHikariCPClient jdbcClient = (JDBCHikariCPClient) client;
+ ConfigService configService = moduleManager.find(CoreModule.NAME).provider().getService(ConfigService.class);
+ int ttl = model.isRecord() ? configService.getRecordDataTTL() : configService.getMetricsDataTTL();
+ if (model.getSqlDBModelExtension().isShardingTable()) {
+ isRuleExecuted = ShardingRulesOperator.INSTANCE.createOrUpdateShardingRule(jdbcClient, model, this.dataSources, ttl);
+ }
+ return isTableExist && !isRuleExecuted;
+ }
+
+ @Override
+ public void start() {
+ delegatee.start();
+ }
+
+ @Override
+ public void createTable(
+ JDBCHikariCPClient client,
+ Connection connection,
+ String tableName,
+ List<ModelColumn> columns,
+ boolean additionalTable) throws JDBCClientException {
+ delegatee.createTable(client, connection, tableName, columns, additionalTable);
+ }
+
+ @Override
+ public void createTableIndexes(
+ JDBCHikariCPClient client,
+ Connection connection,
+ String tableName,
+ List<ModelColumn> columns,
+ boolean additionalTable) throws JDBCClientException {
+ delegatee.createTable(client, connection, tableName, columns, additionalTable);
Review Comment:
The index seems can not be covered by the e2e.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #9904: Refactor jdbc storage implementations to reuse logics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #9904:
URL: https://github.com/apache/skywalking/pull/9904#issuecomment-1305288843
Look like Postgres relative cases failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] sonatype-lift[bot] commented on a diff in pull request #9904: Refactor storage implementations to reuse logics
Posted by GitBox <gi...@apache.org>.
sonatype-lift[bot] commented on code in PR #9904:
URL: https://github.com/apache/skywalking/pull/9904#discussion_r1013583947
##########
oap-server/server-storage-plugin/storage-shardingsphere-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/shardingsphere/ShardingSphereTableInstaller.java:
##########
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.storage.plugin.jdbc.shardingsphere;
+
+import java.util.Set;
+import org.apache.skywalking.oap.server.core.CoreModule;
+import org.apache.skywalking.oap.server.core.config.ConfigService;
+import org.apache.skywalking.oap.server.core.storage.StorageException;
+import org.apache.skywalking.oap.server.core.storage.model.Model;
+import org.apache.skywalking.oap.server.core.storage.model.ModelInstaller;
+import org.apache.skywalking.oap.server.library.client.Client;
+import org.apache.skywalking.oap.server.library.client.jdbc.hikaricp.JDBCHikariCPClient;
+import org.apache.skywalking.oap.server.library.module.ModuleManager;
+import lombok.experimental.Delegate;
+
+public class ShardingSphereTableInstaller extends ModelInstaller {
+ @Delegate
Review Comment:
*[MissingOverride](https://errorprone.info/bugpattern/MissingOverride):* createTable implements method in ModelInstaller; expected @Override
---
```suggestion
@Override @Delegate
```
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not relevant](https://www.sonatype.com/lift-comment-rating?comment=350712141&lift_comment_rating=1) ] - [ [đ Won't fix](https://www.sonatype.com/lift-comment-rating?comment=350712141&lift_comment_rating=2) ] - [ [đ Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=350712141&lift_comment_rating=3) ] - [ [đ Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=350712141&lift_comment_rating=4) ] - [ [đ Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=350712141&lift_comment_rating=5) ]
##########
oap-server/server-storage-plugin/storage-shardingsphere-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/shardingsphere/ShardingSphereTableInstaller.java:
##########
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.storage.plugin.jdbc.shardingsphere;
+
+import java.util.Set;
+import org.apache.skywalking.oap.server.core.CoreModule;
+import org.apache.skywalking.oap.server.core.config.ConfigService;
+import org.apache.skywalking.oap.server.core.storage.StorageException;
+import org.apache.skywalking.oap.server.core.storage.model.Model;
+import org.apache.skywalking.oap.server.core.storage.model.ModelInstaller;
+import org.apache.skywalking.oap.server.library.client.Client;
+import org.apache.skywalking.oap.server.library.client.jdbc.hikaricp.JDBCHikariCPClient;
+import org.apache.skywalking.oap.server.library.module.ModuleManager;
+import lombok.experimental.Delegate;
+
+public class ShardingSphereTableInstaller extends ModelInstaller {
+ @Delegate
Review Comment:
*[MissingOverride](https://errorprone.info/bugpattern/MissingOverride):* whenCreating overrides method in ModelInstaller; expected @Override
---
```suggestion
@Override @Delegate
```
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not relevant](https://www.sonatype.com/lift-comment-rating?comment=350712181&lift_comment_rating=1) ] - [ [đ Won't fix](https://www.sonatype.com/lift-comment-rating?comment=350712181&lift_comment_rating=2) ] - [ [đ Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=350712181&lift_comment_rating=3) ] - [ [đ Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=350712181&lift_comment_rating=4) ] - [ [đ Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=350712181&lift_comment_rating=5) ]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org