You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "ptupitsyn (via GitHub)" <gi...@apache.org> on 2024/05/10 10:44:05 UTC
[PR] IGNITE-21568 Java thin: Pass client time zone to server [ignite-3]
ptupitsyn opened a new pull request, #3737:
URL: https://github.com/apache/ignite-3/pull/3737
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-21568 Java thin: Pass client time zone to server [ignite-3]
Posted by "ptupitsyn (via GitHub)" <gi...@apache.org>.
ptupitsyn commented on code in PR #3737:
URL: https://github.com/apache/ignite-3/pull/3737#discussion_r1598024526
##########
modules/client/src/main/java/org/apache/ignite/internal/client/sql/ClientStatement.java:
##########
@@ -31,14 +31,20 @@ public class ClientStatement implements Statement {
private final String query;
/** Default schema. */
+ @Nullable
Review Comment:
Fixed.
I've used `javax.annotation.Nullable` instead of `org.jetbrains.annotations.Nullable` by mistake, and the IDE displays a warning about incorrect order in that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-21568 Java thin: Pass client time zone to server [ignite-3]
Posted by "isapego (via GitHub)" <gi...@apache.org>.
isapego commented on code in PR #3737:
URL: https://github.com/apache/ignite-3/pull/3737#discussion_r1596791771
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/sql/ClientSqlProperties.java:
##########
@@ -68,6 +75,10 @@ SqlProperties toSqlProps() {
builder.set(QueryProperty.DEFAULT_SCHEMA, schema);
}
+ if (timeZoneId != null) {
+ builder.set(QueryProperty.TIME_ZONE_ID, ZoneId.of(timeZoneId));
+ }
Review Comment:
How are we going to specify or reference the timezone format in other clients? Just give a reference to `java.time.ZoneId` javadocs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-21568 Java thin: Pass client time zone to server [ignite-3]
Posted by "korlov42 (via GitHub)" <gi...@apache.org>.
korlov42 commented on code in PR #3737:
URL: https://github.com/apache/ignite-3/pull/3737#discussion_r1597978516
##########
modules/client/src/main/java/org/apache/ignite/internal/client/sql/ClientStatement.java:
##########
@@ -31,14 +31,20 @@ public class ClientStatement implements Statement {
private final String query;
/** Default schema. */
+ @Nullable
Review Comment:
according to our [coding guidelines](https://google.github.io/styleguide/javaguide.html#s4.8.5-annotations), type-use annotations appear immediately before the annotated type. Please fix it in other places too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-21568 Java thin: Pass client time zone to server [ignite-3]
Posted by "ptupitsyn (via GitHub)" <gi...@apache.org>.
ptupitsyn commented on code in PR #3737:
URL: https://github.com/apache/ignite-3/pull/3737#discussion_r1597880038
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/sql/ClientSqlProperties.java:
##########
@@ -68,6 +75,10 @@ SqlProperties toSqlProps() {
builder.set(QueryProperty.DEFAULT_SCHEMA, schema);
}
+ if (timeZoneId != null) {
+ builder.set(QueryProperty.TIME_ZONE_ID, ZoneId.of(timeZoneId));
+ }
Review Comment:
Yes, the javadoc explains it in detail: [ZoneId#of](https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/time/ZoneId.html#of(java.lang.String))
It supports standard [IANA region-based zone IDs](https://en.wikipedia.org/wiki/List_of_tz_database_time_zones), so I expect every client to have something suitable in the standard library or a popular package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-21568 Java thin: Pass client time zone to server [ignite-3]
Posted by "ptupitsyn (via GitHub)" <gi...@apache.org>.
ptupitsyn merged PR #3737:
URL: https://github.com/apache/ignite-3/pull/3737
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org