You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Mikhail Antonov (JIRA)" <ji...@apache.org> on 2014/05/10 23:58:58 UTC

[jira] [Commented] (HBASE-11147) Avoid creating List of KeyValue in FilterBase#filterRowCells(List)

    [ https://issues.apache.org/jira/browse/HBASE-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13993932#comment-13993932 ] 

Mikhail Antonov commented on HBASE-11147:
-----------------------------------------

Unless I'm missing something, you can't do (ignored instanceof List<KeyValue>), because of type erasure in generic?

> Avoid creating List of KeyValue in FilterBase#filterRowCells(List<Cell>)
> ------------------------------------------------------------------------
>
>                 Key: HBASE-11147
>                 URL: https://issues.apache.org/jira/browse/HBASE-11147
>             Project: HBase
>          Issue Type: Task
>            Reporter: Ted Yu
>            Priority: Minor
>
> Currently a List of KeyValue's is always created:
> {code}
>     List<KeyValue> kvs = new ArrayList<KeyValue>(ignored.size());
> {code}
> When passed ignored List is of KeyValue (which is the only implementation of Cell at the moment), the above step should be avoided.
> This would reduce creation of short-lived objects.



--
This message was sent by Atlassian JIRA
(v6.2#6252)