[jira] [Commented] (AIRFLOW-7031) Airflow WinRM endpoint is hardcoded to HTTP

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-7031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17056096#comment-17056096 ] 

ASF GitHub Bot commented on AIRFLOW-7031:
-----------------------------------------

NBardelot commented on pull request #7682: [AIRFLOW-7031] Airflow WinRM endpoint is hardcoded to HTTP
URL: https://github.com/apache/airflow/pull/7682
 
 
    This commit fixes the issue and avoid errors like this:
   
   ```
   ERROR - Error connecting to host: 1.2.3.4, error: HTTPConnectionPool(host='1.2.3.4', port=5986): Read timed out. (read timeout=30)
   ```
   
   Even when `service` is set to `HTTPS` because the WinRM hook `endpoint`'s default configuration was hardcoded with the `http://` protocol.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Airflow WinRM endpoint is hardcoded to HTTP
> -------------------------------------------
>
>                 Key: AIRFLOW-7031
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-7031
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: hooks
>    Affects Versions: 1.10.9
>            Reporter: Noël BARDELOT
>            Priority: Minor
>
> In airflow/providers/microsoft/winrm/hooks/winrm.py the following code is hardcoded to use 'http' even when the service is set to use 'https':
>  
> {{ # If endpoint is not set, then build a standard wsman endpoint from host and port.}}
> {{ if not self.endpoint:}}
> {{   self.endpoint = 'http://\{0}:\{1}/wsman'.format(self.remote_host, self.remote_port)}}
>  
> Workaround: configure the 'enpoint' setting manually in the extra configuration of the connection.
> Correction: make the protocol configurable, depending on the value of the 'service' configuration (if 'HTTP' then 'http://' should be used, and if 'HTTPS' then 'https://' should be used).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)