You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by ortutay <gi...@git.apache.org> on 2018/09/16 04:15:12 UTC

[GitHub] phoenix pull request #350: PHOENIX-4903 Use same hash cache RPC message acro...

GitHub user ortutay opened a pull request:

    https://github.com/apache/phoenix/pull/350

    PHOENIX-4903 Use same hash cache RPC message across all calls

    See ticket https://issues.apache.org/jira/browse/PHOENIX-4903 , this change makes it so a single RPC message is used to distribute the hash cache across region servers. The previous code would have O(N) memory usage. This has O(1) memory usage.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ortutay/phoenix PHOENIX-4903-hash-cache-rpc-message-mem

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/phoenix/pull/350.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #350
    
----
commit 0d11f7a388ce0e856329ef7e93a719433229e5df
Author: Marcell Ortutay <ma...@...>
Date:   2018-09-16T04:13:54Z

    PHOENIX-4903 Use same hash cache RPC message across all calls

----


---

[GitHub] phoenix pull request #350: PHOENIX-4903 Use same hash cache RPC message acro...

Posted by ortutay <gi...@git.apache.org>.

Github user ortutay closed the pull request at:

    https://github.com/apache/phoenix/pull/350


---

[GitHub] phoenix issue #350: PHOENIX-4903 Use same hash cache RPC message across all ...

Posted by joshelser <gi...@git.apache.org>.

Github user joshelser commented on the issue:

    https://github.com/apache/phoenix/pull/350
  
    +1 let me check the tests and merge it. Super straightforward. Thanks Marcell!


---

[GitHub] phoenix issue #350: PHOENIX-4903 Use same hash cache RPC message across all ...

Posted by ortutay <gi...@git.apache.org>.

Github user ortutay commented on the issue:

    https://github.com/apache/phoenix/pull/350
  
    Done!


---

[GitHub] phoenix issue #350: PHOENIX-4903 Use same hash cache RPC message across all ...

Posted by joshelser <gi...@git.apache.org>.

Github user joshelser commented on the issue:

    https://github.com/apache/phoenix/pull/350
  
    Sorry, I forgot to include the text to automatically close this in the commit message. Can you click the "close pull request" button please, @ortutay?


---