You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Auston McReynolds (JIRA)" <ji...@codehaus.org> on 2007/07/17 01:14:13 UTC

[jira] Created: (MECLIPSE-305) souce-path is absolute versus relative with WAR

souce-path is absolute versus relative with WAR
-----------------------------------------------

                 Key: MECLIPSE-305
                 URL: http://jira.codehaus.org/browse/MECLIPSE-305
             Project: Maven 2.x Eclipse Plugin
          Issue Type: Bug
          Components: WTP support
    Affects Versions: 2.4
         Environment: Windows 2003
            Reporter: Auston McReynolds


Tested against 2.4 and TRUNK.
Works as expected with 2.3

org\apache\maven\plugin\eclipse\writers\wtp\EclipseWtpComponentWriter.java
in the if-block
if ( "war".equalsIgnoreCase( packaging ) ) 

...

writer.addAttribute( ATTR_SOURCE_PATH, IdeUtils
    .toRelativeAndFixSeparator( config.getEclipseProjectDirectory(), new File( warSourceDirectory ), false ) );

Should be

writer.addAttribute( ATTR_SOURCE_PATH, IdeUtils
    .toRelativeAndFixSeparator( config.getProject().getBasedir(), new File( config
    .getEclipseProjectDirectory(), warSourceDirectory ), false ) );


Without Patch:
<wb-resource 
        deploy-path="/" 
        source-path="D:/xxx/aaa/bbb/WebContent"/> 

After Patch:
<wb-resource 
                deploy-path="/" 
                source-path="WebContent"/> 


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MECLIPSE-305) souce-path is absolute versus relative with WAR

Posted by "Auston McReynolds (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MECLIPSE-305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Auston McReynolds closed MECLIPSE-305.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.5

Fixed in 2.5-SNAPSHOT
Thanks

> souce-path is absolute versus relative with WAR
> -----------------------------------------------
>
>                 Key: MECLIPSE-305
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-305
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: WTP support
>    Affects Versions: 2.4
>         Environment: Windows 2003
>            Reporter: Auston McReynolds
>             Fix For: 2.5
>
>
> Tested against 2.4 and TRUNK.
> Works as expected with 2.3
> org\apache\maven\plugin\eclipse\writers\wtp\EclipseWtpComponentWriter.java
> in the if-block
> if ( "war".equalsIgnoreCase( packaging ) ) 
> ...
> writer.addAttribute( ATTR_SOURCE_PATH, IdeUtils
>     .toRelativeAndFixSeparator( config.getEclipseProjectDirectory(), new File( warSourceDirectory ), false ) );
> Should be
> writer.addAttribute( ATTR_SOURCE_PATH, IdeUtils
>     .toRelativeAndFixSeparator( config.getProject().getBasedir(), new File( config
>     .getEclipseProjectDirectory(), warSourceDirectory ), false ) );
> Without Patch:
> <wb-resource 
>         deploy-path="/" 
>         source-path="D:/xxx/aaa/bbb/WebContent"/> 
> After Patch:
> <wb-resource 
>                 deploy-path="/" 
>                 source-path="WebContent"/> 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MECLIPSE-305) souce-path is absolute versus relative with WAR

Posted by "Dan Tran (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MECLIPSE-305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Tran closed MECLIPSE-305.
-----------------------------

    Resolution: Duplicate

> souce-path is absolute versus relative with WAR
> -----------------------------------------------
>
>                 Key: MECLIPSE-305
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-305
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: WTP support
>    Affects Versions: 2.4
>         Environment: Windows 2003
>            Reporter: Auston McReynolds
>             Fix For: 2.5
>
>
> Tested against 2.4 and TRUNK.
> Works as expected with 2.3
> org\apache\maven\plugin\eclipse\writers\wtp\EclipseWtpComponentWriter.java
> in the if-block
> if ( "war".equalsIgnoreCase( packaging ) ) 
> ...
> writer.addAttribute( ATTR_SOURCE_PATH, IdeUtils
>     .toRelativeAndFixSeparator( config.getEclipseProjectDirectory(), new File( warSourceDirectory ), false ) );
> Should be
> writer.addAttribute( ATTR_SOURCE_PATH, IdeUtils
>     .toRelativeAndFixSeparator( config.getProject().getBasedir(), new File( config
>     .getEclipseProjectDirectory(), warSourceDirectory ), false ) );
> Without Patch:
> <wb-resource 
>         deploy-path="/" 
>         source-path="D:/xxx/aaa/bbb/WebContent"/> 
> After Patch:
> <wb-resource 
>                 deploy-path="/" 
>                 source-path="WebContent"/> 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MECLIPSE-305) souce-path is absolute versus relative with WAR

Posted by "Dan Tran (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MECLIPSE-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_102426 ] 

Dan Tran commented on MECLIPSE-305:
-----------------------------------

This should be fixed in tp://jira.codehaus.org/browse/MECLIPSE-296

You can fetch the latest 2.5-SNAPSHOT source and try it out.

> souce-path is absolute versus relative with WAR
> -----------------------------------------------
>
>                 Key: MECLIPSE-305
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-305
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: WTP support
>    Affects Versions: 2.4
>         Environment: Windows 2003
>            Reporter: Auston McReynolds
>
> Tested against 2.4 and TRUNK.
> Works as expected with 2.3
> org\apache\maven\plugin\eclipse\writers\wtp\EclipseWtpComponentWriter.java
> in the if-block
> if ( "war".equalsIgnoreCase( packaging ) ) 
> ...
> writer.addAttribute( ATTR_SOURCE_PATH, IdeUtils
>     .toRelativeAndFixSeparator( config.getEclipseProjectDirectory(), new File( warSourceDirectory ), false ) );
> Should be
> writer.addAttribute( ATTR_SOURCE_PATH, IdeUtils
>     .toRelativeAndFixSeparator( config.getProject().getBasedir(), new File( config
>     .getEclipseProjectDirectory(), warSourceDirectory ), false ) );
> Without Patch:
> <wb-resource 
>         deploy-path="/" 
>         source-path="D:/xxx/aaa/bbb/WebContent"/> 
> After Patch:
> <wb-resource 
>                 deploy-path="/" 
>                 source-path="WebContent"/> 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Reopened: (MECLIPSE-305) souce-path is absolute versus relative with WAR

Posted by "Dan Tran (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MECLIPSE-305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Tran reopened MECLIPSE-305:
-------------------------------


> souce-path is absolute versus relative with WAR
> -----------------------------------------------
>
>                 Key: MECLIPSE-305
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-305
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: WTP support
>    Affects Versions: 2.4
>         Environment: Windows 2003
>            Reporter: Auston McReynolds
>             Fix For: 2.5
>
>
> Tested against 2.4 and TRUNK.
> Works as expected with 2.3
> org\apache\maven\plugin\eclipse\writers\wtp\EclipseWtpComponentWriter.java
> in the if-block
> if ( "war".equalsIgnoreCase( packaging ) ) 
> ...
> writer.addAttribute( ATTR_SOURCE_PATH, IdeUtils
>     .toRelativeAndFixSeparator( config.getEclipseProjectDirectory(), new File( warSourceDirectory ), false ) );
> Should be
> writer.addAttribute( ATTR_SOURCE_PATH, IdeUtils
>     .toRelativeAndFixSeparator( config.getProject().getBasedir(), new File( config
>     .getEclipseProjectDirectory(), warSourceDirectory ), false ) );
> Without Patch:
> <wb-resource 
>         deploy-path="/" 
>         source-path="D:/xxx/aaa/bbb/WebContent"/> 
> After Patch:
> <wb-resource 
>                 deploy-path="/" 
>                 source-path="WebContent"/> 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira