[GitHub] [spark] HyukjinKwon commented on a change in pull request #35064: [SPARK-37783][SS][SQL][CORE] Enable tail-recursive wherever possible

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #35064:
URL: https://github.com/apache/spark/pull/35064#discussion_r776553602



##########
File path: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
##########
@@ -751,6 +751,14 @@ private[history] class FsHistoryProvider(conf: SparkConf, clock: Clock)
    * Visible for testing
    */
   private[history] def doMergeApplicationListing(
+      reader: EventLogFileReader,
+      scanTime: Long,
+      enableOptimizations: Boolean,
+      lastEvaluatedForCompaction: Option[Long]): Unit = mergeApplicationListing(
+    reader, scanTime, enableOptimizations, lastEvaluatedForCompaction)
+
+  @scala.annotation.tailrec
+  private def mergeApplicationListing(

Review comment:
       Otherwise:
   
   ```
   [error] /home/runner/work/spark/spark/core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala:754:24: could not optimize @tailrec annotated method doMergeApplicationListing: it is neither private nor final so can be overridden
   [error]   private[history] def doMergeApplicationListing(
   [error]                        ^
   [error] one error found
   [error] (core / Compile / compileIncremental) Compilation failed
   [error] Total time: 204 s (03:24), completed Dec 30, 2021 2:54:38 AM
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org