You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "ryan rawson (JIRA)" <ji...@apache.org> on 2009/03/19 01:47:50 UTC
[jira] Created: (HBASE-1267) binary keys broken in trunk (again).
binary keys broken in trunk (again).
------------------------------------
Key: HBASE-1267
URL: https://issues.apache.org/jira/browse/HBASE-1267
Project: Hadoop HBase
Issue Type: Bug
Affects Versions: 0.20.0
Reporter: ryan rawson
Fix For: 0.20.0
Binary keys, specifically ones where the first byte of the key is nul '\0' don't work:
- Splits happen
- Logfile indicates everything normal
But the .META. doesnt list all the regions. It only lists the 'basic' regions: 'table,,1234'. The other regions with the binary keys in the middle just dont seem to be in .META....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1267) binary keys broken in trunk (again).
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-1267:
-------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Applied part 2 and 3.
> binary keys broken in trunk (again).
> ------------------------------------
>
> Key: HBASE-1267
> URL: https://issues.apache.org/jira/browse/HBASE-1267
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: ryan rawson
> Fix For: 0.20.0
>
> Attachments: HBASE-1267-2.patch, HBASE-1267-3.patch, HBASE-1267.patch
>
>
> Binary keys, specifically ones where the first byte of the key is nul '\0' don't work:
> - Splits happen
> - Logfile indicates everything normal
> But the .META. doesnt list all the regions. It only lists the 'basic' regions: 'table,,1234'. The other regions with the binary keys in the middle just dont seem to be in .META....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1267) binary keys broken in trunk (again).
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683272#action_12683272 ]
Nitay Joffe commented on HBASE-1267:
------------------------------------
Minor thing: Why create a Comparator on each HScanner construction? We could just call HStoreKey#getRawComparator(HRegionInfo), which should be fixed when HBASE-1262 gets put in. Furthermore, why not make all our Comparators have a private/protected constructor and a static instance everyone retrieves (i.e. Singleton pattern)?
> binary keys broken in trunk (again).
> ------------------------------------
>
> Key: HBASE-1267
> URL: https://issues.apache.org/jira/browse/HBASE-1267
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: ryan rawson
> Fix For: 0.20.0
>
> Attachments: HBASE-1267.patch
>
>
> Binary keys, specifically ones where the first byte of the key is nul '\0' don't work:
> - Splits happen
> - Logfile indicates everything normal
> But the .META. doesnt list all the regions. It only lists the 'basic' regions: 'table,,1234'. The other regions with the binary keys in the middle just dont seem to be in .META....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1267) binary keys broken in trunk (again).
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ryan rawson updated HBASE-1267:
-------------------------------
Attachment: HBASE-1267-3.patch
turns out the memcache scanner was causing problems, which was causing an assignment loop because we didnt find values in the memcache while scanning, thus never knew about the new assignments.
> binary keys broken in trunk (again).
> ------------------------------------
>
> Key: HBASE-1267
> URL: https://issues.apache.org/jira/browse/HBASE-1267
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: ryan rawson
> Fix For: 0.20.0
>
> Attachments: HBASE-1267-2.patch, HBASE-1267-3.patch, HBASE-1267.patch
>
>
> Binary keys, specifically ones where the first byte of the key is nul '\0' don't work:
> - Splits happen
> - Logfile indicates everything normal
> But the .META. doesnt list all the regions. It only lists the 'basic' regions: 'table,,1234'. The other regions with the binary keys in the middle just dont seem to be in .META....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-1267) binary keys broken in trunk (again).
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-1267.
--------------------------
Resolution: Fixed
Resolve again. Thanks for the review Nitay. Good stuff lads.
> binary keys broken in trunk (again).
> ------------------------------------
>
> Key: HBASE-1267
> URL: https://issues.apache.org/jira/browse/HBASE-1267
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: ryan rawson
> Fix For: 0.20.0
>
> Attachments: HBASE-1267-2.patch, HBASE-1267.patch
>
>
> Binary keys, specifically ones where the first byte of the key is nul '\0' don't work:
> - Splits happen
> - Logfile indicates everything normal
> But the .META. doesnt list all the regions. It only lists the 'basic' regions: 'table,,1234'. The other regions with the binary keys in the middle just dont seem to be in .META....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (HBASE-1267) binary keys broken in trunk (again).
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ryan rawson reopened HBASE-1267:
--------------------------------
still buggy, newest patch fixes.
> binary keys broken in trunk (again).
> ------------------------------------
>
> Key: HBASE-1267
> URL: https://issues.apache.org/jira/browse/HBASE-1267
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: ryan rawson
> Fix For: 0.20.0
>
> Attachments: HBASE-1267-2.patch, HBASE-1267-3.patch, HBASE-1267.patch
>
>
> Binary keys, specifically ones where the first byte of the key is nul '\0' don't work:
> - Splits happen
> - Logfile indicates everything normal
> But the .META. doesnt list all the regions. It only lists the 'basic' regions: 'table,,1234'. The other regions with the binary keys in the middle just dont seem to be in .META....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (HBASE-1267) binary keys broken in trunk (again).
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ryan rawson reopened HBASE-1267:
--------------------------------
see new patch that fixes nitay's concerns.
> binary keys broken in trunk (again).
> ------------------------------------
>
> Key: HBASE-1267
> URL: https://issues.apache.org/jira/browse/HBASE-1267
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: ryan rawson
> Fix For: 0.20.0
>
> Attachments: HBASE-1267-2.patch, HBASE-1267.patch
>
>
> Binary keys, specifically ones where the first byte of the key is nul '\0' don't work:
> - Splits happen
> - Logfile indicates everything normal
> But the .META. doesnt list all the regions. It only lists the 'basic' regions: 'table,,1234'. The other regions with the binary keys in the middle just dont seem to be in .META....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1267) binary keys broken in trunk (again).
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-1267:
-------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Excellent. Good one Ryan. Thanks for the patch.
> binary keys broken in trunk (again).
> ------------------------------------
>
> Key: HBASE-1267
> URL: https://issues.apache.org/jira/browse/HBASE-1267
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: ryan rawson
> Fix For: 0.20.0
>
> Attachments: HBASE-1267.patch
>
>
> Binary keys, specifically ones where the first byte of the key is nul '\0' don't work:
> - Splits happen
> - Logfile indicates everything normal
> But the .META. doesnt list all the regions. It only lists the 'basic' regions: 'table,,1234'. The other regions with the binary keys in the middle just dont seem to be in .META....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1267) binary keys broken in trunk (again).
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ryan rawson updated HBASE-1267:
-------------------------------
Attachment: HBASE-1267.patch
Turns out we werent using the correct comparator in the scanner for all contexts. IF we dont use the meta comparator then we run into issues where we have 2 rows like so:
table,,1234
table,\0,12345
without the meta comparator, we compare the ',' and the '\0' and the scanner thinks the underlying store file is out of order.
> binary keys broken in trunk (again).
> ------------------------------------
>
> Key: HBASE-1267
> URL: https://issues.apache.org/jira/browse/HBASE-1267
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: ryan rawson
> Fix For: 0.20.0
>
> Attachments: HBASE-1267.patch
>
>
> Binary keys, specifically ones where the first byte of the key is nul '\0' don't work:
> - Splits happen
> - Logfile indicates everything normal
> But the .META. doesnt list all the regions. It only lists the 'basic' regions: 'table,,1234'. The other regions with the binary keys in the middle just dont seem to be in .META....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1267) binary keys broken in trunk (again).
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ryan rawson updated HBASE-1267:
-------------------------------
Attachment: HBASE-1267-2.patch
nitay is right on here, we should use these convenience functions and reuse the static object.
> binary keys broken in trunk (again).
> ------------------------------------
>
> Key: HBASE-1267
> URL: https://issues.apache.org/jira/browse/HBASE-1267
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: ryan rawson
> Fix For: 0.20.0
>
> Attachments: HBASE-1267-2.patch, HBASE-1267.patch
>
>
> Binary keys, specifically ones where the first byte of the key is nul '\0' don't work:
> - Splits happen
> - Logfile indicates everything normal
> But the .META. doesnt list all the regions. It only lists the 'basic' regions: 'table,,1234'. The other regions with the binary keys in the middle just dont seem to be in .META....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HBASE-1267) binary keys broken in trunk (again).
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ryan rawson reassigned HBASE-1267:
----------------------------------
Assignee: ryan rawson
> binary keys broken in trunk (again).
> ------------------------------------
>
> Key: HBASE-1267
> URL: https://issues.apache.org/jira/browse/HBASE-1267
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: ryan rawson
> Fix For: 0.20.0
>
> Attachments: HBASE-1267.patch
>
>
> Binary keys, specifically ones where the first byte of the key is nul '\0' don't work:
> - Splits happen
> - Logfile indicates everything normal
> But the .META. doesnt list all the regions. It only lists the 'basic' regions: 'table,,1234'. The other regions with the binary keys in the middle just dont seem to be in .META....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1267) binary keys broken in trunk (again).
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ryan rawson updated HBASE-1267:
-------------------------------
Status: Patch Available (was: Open)
> binary keys broken in trunk (again).
> ------------------------------------
>
> Key: HBASE-1267
> URL: https://issues.apache.org/jira/browse/HBASE-1267
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: ryan rawson
> Fix For: 0.20.0
>
> Attachments: HBASE-1267.patch
>
>
> Binary keys, specifically ones where the first byte of the key is nul '\0' don't work:
> - Splits happen
> - Logfile indicates everything normal
> But the .META. doesnt list all the regions. It only lists the 'basic' regions: 'table,,1234'. The other regions with the binary keys in the middle just dont seem to be in .META....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1267) binary keys broken in trunk (again).
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ryan rawson updated HBASE-1267:
-------------------------------
Status: Patch Available (was: Reopened)
> binary keys broken in trunk (again).
> ------------------------------------
>
> Key: HBASE-1267
> URL: https://issues.apache.org/jira/browse/HBASE-1267
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: ryan rawson
> Fix For: 0.20.0
>
> Attachments: HBASE-1267-2.patch, HBASE-1267-3.patch, HBASE-1267.patch
>
>
> Binary keys, specifically ones where the first byte of the key is nul '\0' don't work:
> - Splits happen
> - Logfile indicates everything normal
> But the .META. doesnt list all the regions. It only lists the 'basic' regions: 'table,,1234'. The other regions with the binary keys in the middle just dont seem to be in .META....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.