[GitHub] [storm] agresch commented on a change in pull request #3208: [STORM-3579] use the topo conf for thrift client in Worker code

[GitBox <gi...@apache.org>]

agresch commented on a change in pull request #3208: [STORM-3579]  use the topo conf for thrift client in Worker code
URL: https://github.com/apache/storm/pull/3208#discussion_r377674522
 
 

 ##########
 File path: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
 ##########
 @@ -443,7 +451,7 @@ private void heartbeatToMasterIfLocalbeatFail(LSWorkerHeartbeat lsWorkerHeartbea
         } catch (Exception tr1) {
             //If any error/exception thrown, report directly to nimbus.
             LOG.warn("Exception when send heartbeat to local supervisor", tr1.getMessage());
-            try (NimbusClient nimbusClient = NimbusClient.getConfiguredClient(conf)) {
+            try (NimbusClient nimbusClient = NimbusClient.getConfiguredClient(topologyConf)) {
 
 Review comment:
   Can you update the javadoc for NimbusClient.getConfiguredClient() to indicate it needs a topoconf?
   
   Are there any other uses of NimbusClient.getConfiguredClient() that need fixing?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services