You are viewing a plain text version of this content. The canonical link for it is here.
Posted to droids-dev@incubator.apache.org by "Eugen Paraschiv (JIRA)" <ji...@apache.org> on 2011/02/15 21:38:57 UTC
[jira] Created: (DROIDS-122) Make consistent use of the @Override
annotation
Make consistent use of the @Override annotation
-----------------------------------------------
Key: DROIDS-122
URL: https://issues.apache.org/jira/browse/DROIDS-122
Project: Droids
Issue Type: Improvement
Components: core
Affects Versions: 0.0.2
Reporter: Eugen Paraschiv
Priority: Minor
Fix For: 0.0.2
The @Override annotation is used inconsistently in the code. There are several examples of this - SimpleTaskQueue - some of the methods do use @Override but some of them do not.
A suggestion to solve this issue is to commit the Eclipse Save Actions settings, so that (when using Eclipse), the @Override annotation is going to be automatically added.
Either way, the annotation should be used consistently throughout the code base.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DROIDS-122) Make consistent use of the @Override
annotation
Posted by "Richard Frovarp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004008#comment-13004008 ]
Richard Frovarp commented on DROIDS-122:
----------------------------------------
Rest of the patch has been applied in r1079404
> Make consistent use of the @Override annotation
> -----------------------------------------------
>
> Key: DROIDS-122
> URL: https://issues.apache.org/jira/browse/DROIDS-122
> Project: Droids
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.0.1
> Reporter: Eugen Paraschiv
> Assignee: Richard Frovarp
> Priority: Minor
> Fix For: 0.0.1
>
> Attachments: DROIDS-122.patch
>
>
> The @Override annotation is used inconsistently in the code. There are several examples of this - SimpleTaskQueue - some of the methods do use @Override but some of them do not.
> A suggestion to solve this issue is to commit the Eclipse Save Actions settings, so that (when using Eclipse), the @Override annotation is going to be automatically added.
> Either way, the annotation should be used consistently throughout the code base.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DROIDS-122) Make consistent use of the @Override
annotation
Posted by "Richard Frovarp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard Frovarp updated DROIDS-122:
-----------------------------------
Fix Version/s: (was: 0.0.2)
0.0.1
Assignee: Richard Frovarp
Affects Version/s: (was: 0.0.2)
0.0.1
> Make consistent use of the @Override annotation
> -----------------------------------------------
>
> Key: DROIDS-122
> URL: https://issues.apache.org/jira/browse/DROIDS-122
> Project: Droids
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.0.1
> Reporter: Eugen Paraschiv
> Assignee: Richard Frovarp
> Priority: Minor
> Fix For: 0.0.1
>
> Attachments: DROIDS-122.patch
>
>
> The @Override annotation is used inconsistently in the code. There are several examples of this - SimpleTaskQueue - some of the methods do use @Override but some of them do not.
> A suggestion to solve this issue is to commit the Eclipse Save Actions settings, so that (when using Eclipse), the @Override annotation is going to be automatically added.
> Either way, the annotation should be used consistently throughout the code base.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DROIDS-122) Make consistent use of the @Override
annotation
Posted by "Jeremy Arnold (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremy Arnold updated DROIDS-122:
---------------------------------
Attachment: DROIDS-122.patch
@Override annotations on interface implementations as well as overriden methods from superclass.
> Make consistent use of the @Override annotation
> -----------------------------------------------
>
> Key: DROIDS-122
> URL: https://issues.apache.org/jira/browse/DROIDS-122
> Project: Droids
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.0.2
> Reporter: Eugen Paraschiv
> Priority: Minor
> Fix For: 0.0.2
>
> Attachments: DROIDS-122.patch
>
>
> The @Override annotation is used inconsistently in the code. There are several examples of this - SimpleTaskQueue - some of the methods do use @Override but some of them do not.
> A suggestion to solve this issue is to commit the Eclipse Save Actions settings, so that (when using Eclipse), the @Override annotation is going to be automatically added.
> Either way, the annotation should be used consistently throughout the code base.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DROIDS-122) Make consistent use of the @Override
annotation
Posted by "Richard Frovarp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003996#comment-13003996 ]
Richard Frovarp commented on DROIDS-122:
----------------------------------------
Patch did not apply cleanly. The parts that did apply cleanly went in in r1079393. Will now do the few pieces that didn't go in cleanly.
> Make consistent use of the @Override annotation
> -----------------------------------------------
>
> Key: DROIDS-122
> URL: https://issues.apache.org/jira/browse/DROIDS-122
> Project: Droids
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.0.1
> Reporter: Eugen Paraschiv
> Assignee: Richard Frovarp
> Priority: Minor
> Fix For: 0.0.1
>
> Attachments: DROIDS-122.patch
>
>
> The @Override annotation is used inconsistently in the code. There are several examples of this - SimpleTaskQueue - some of the methods do use @Override but some of them do not.
> A suggestion to solve this issue is to commit the Eclipse Save Actions settings, so that (when using Eclipse), the @Override annotation is going to be automatically added.
> Either way, the annotation should be used consistently throughout the code base.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (DROIDS-122) Make consistent use of the @Override
annotation
Posted by "Richard Frovarp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard Frovarp resolved DROIDS-122.
------------------------------------
Resolution: Fixed
Current code base should be fixed. Thanks to Jeremy Arnold for the patch.
> Make consistent use of the @Override annotation
> -----------------------------------------------
>
> Key: DROIDS-122
> URL: https://issues.apache.org/jira/browse/DROIDS-122
> Project: Droids
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.0.1
> Reporter: Eugen Paraschiv
> Assignee: Richard Frovarp
> Priority: Minor
> Fix For: 0.0.1
>
> Attachments: DROIDS-122.patch
>
>
> The @Override annotation is used inconsistently in the code. There are several examples of this - SimpleTaskQueue - some of the methods do use @Override but some of them do not.
> A suggestion to solve this issue is to commit the Eclipse Save Actions settings, so that (when using Eclipse), the @Override annotation is going to be automatically added.
> Either way, the annotation should be used consistently throughout the code base.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira