You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/09/11 22:25:05 UTC

[GitHub] [incubator-gobblin] autumnust opened a new pull request #3104: [GOBBLIN-1263] Dataset specific Database name for registration

autumnust opened a new pull request #3104:
URL: https://github.com/apache/incubator-gobblin/pull/3104


   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   -  https://issues.apache.org/jira/browse/GOBBLIN-1263
   
   ### Description
   This PR enables dataset-level configuration for the database to register against. 
   
   
   ### Tests
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-gobblin] asfgit closed pull request #3104: [GOBBLIN-1263] Dataset specific Database name for registration

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3104:
URL: https://github.com/apache/incubator-gobblin/pull/3104


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-gobblin] sv2000 commented on pull request #3104: [GOBBLIN-1263] Dataset specific Database name for registration

Posted by GitBox <gi...@apache.org>.
sv2000 commented on pull request #3104:
URL: https://github.com/apache/incubator-gobblin/pull/3104#issuecomment-691341808






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-gobblin] sv2000 commented on pull request #3104: [GOBBLIN-1263] Dataset specific Database name for registration

Posted by GitBox <gi...@apache.org>.
sv2000 commented on pull request #3104:
URL: https://github.com/apache/incubator-gobblin/pull/3104#issuecomment-691341808


   @autumnust Please add PR description.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-gobblin] asfgit closed pull request #3104: [GOBBLIN-1263] Dataset specific Database name for registration

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3104:
URL: https://github.com/apache/incubator-gobblin/pull/3104






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-gobblin] sv2000 commented on pull request #3104: [GOBBLIN-1263] Dataset specific Database name for registration

Posted by GitBox <gi...@apache.org>.
sv2000 commented on pull request #3104:
URL: https://github.com/apache/incubator-gobblin/pull/3104#issuecomment-691341808






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-gobblin] asfgit closed pull request #3104: [GOBBLIN-1263] Dataset specific Database name for registration

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3104:
URL: https://github.com/apache/incubator-gobblin/pull/3104


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org