[GitHub] [maven] hgschmie commented on a diff in pull request #789: [MNG-7529] Maven resolver makes bad repository choices

[GitBox <gi...@apache.org>]

hgschmie commented on code in PR #789:
URL: https://github.com/apache/maven/pull/789#discussion_r956268261


##########
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java:
##########
@@ -195,6 +199,18 @@ private Map<String, ArtifactRepository> getVersions( RepositorySystemSession ses
         return versionIndex;
     }
 
+    private boolean isEnabled( RemoteRepository remoteRepository, String version )
+    {
+        if ( remoteRepository == null )
+        {
+            return true;
+        }
+
+        boolean snapshot = version != null && version.endsWith( SNAPSHOT );

Review Comment:
   Hi @cstamas ,
   
   Thank you for looking at this. I am not I understand this comment. The check is similar to the code in the DefaultVersionResolver (where it determines whether a local file is a SNAPSHOT version by checking that it ends with 'SNAPSHOT' (https://github.com/apache/maven/blob/master/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionResolver.java#L208).
   
   Can you explain a bit more what you mean by "timestamped snapshots" ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org