You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/04/21 08:54:52 UTC
[GitHub] [mynewt-nimble] rymanluk opened a new pull request #804: nimble/gap: Fix storing CCC for bonded devices.
rymanluk opened a new pull request #804:
URL: https://github.com/apache/mynewt-nimble/pull/804
This PR make sure that ble_gatts_bonding_established is called only when
bonded.
Note: renamed not used "persist_keys" to "bonded" and make use of it
Bug can be easly reproduced when
BLE_SM_BONDING: 0
BLE_HS_DEBUG: 1
Program received signal SIGTRAP, Trace/breakpoint trap.
ble_gatts_bonding_established (conn_handle=conn_handle@entry=1) at repos/apache-mynewt-nimble/nimble/host/src/ble_gatts.c:1681
1681 BLE_HS_DBG_ASSERT(conn->bhc_sec_state.bonded);
(gdb)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] rymanluk commented on issue #804: nimble/gap: Fix storing CCC for bonded devices.
Posted by GitBox <gi...@apache.org>.
rymanluk commented on issue #804:
URL: https://github.com/apache/mynewt-nimble/pull/804#issuecomment-617051053
@h2zero could you please have a look on that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] h2zero commented on issue #804: nimble/gap: Fix storing CCC for bonded devices.
Posted by GitBox <gi...@apache.org>.
h2zero commented on issue #804:
URL: https://github.com/apache/mynewt-nimble/pull/804#issuecomment-617521775
@rymanluk Just put it through testing and works as it should 👍.
A quick note for @prasad-alatkar for this PR to work on the esp32 we also need #730
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #804: nimble/gap: Fix storing CCC for bonded devices.
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on issue #804:
URL: https://github.com/apache/mynewt-nimble/pull/804#issuecomment-617076748
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/host/src/ble_sm_priv.h
<details>
```diff
@@ -279,10 +279,10 @@
uint8_t sm_err;
struct ble_gap_passkey_params passkey_params;
void *state_arg;
- unsigned execute:1;
- unsigned enc_cb:1;
- unsigned bonded:1;
- unsigned restore:1;
+ unsigned execute : 1;
+ unsigned enc_cb : 1;
+ unsigned bonded : 1;
+ unsigned restore : 1;
};
#if MYNEWT_VAL(BLE_HS_DEBUG)
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #804: nimble/gap: Fix storing CCC for bonded devices.
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #804:
URL: https://github.com/apache/mynewt-nimble/pull/804#issuecomment-617236935
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #804: nimble/gap: Fix storing CCC for bonded devices.
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #804:
URL: https://github.com/apache/mynewt-nimble/pull/804#issuecomment-617076748
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/host/src/ble_sm_priv.h
<details>
```diff
@@ -279,10 +279,10 @@
uint8_t sm_err;
struct ble_gap_passkey_params passkey_params;
void *state_arg;
- unsigned execute:1;
- unsigned enc_cb:1;
- unsigned bonded:1;
- unsigned restore:1;
+ unsigned execute : 1;
+ unsigned enc_cb : 1;
+ unsigned bonded : 1;
+ unsigned restore : 1;
};
#if MYNEWT_VAL(BLE_HS_DEBUG)
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org