[jira] [Commented] (CB-10522) Event binding in Hello World is misleading

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-10522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137640#comment-15137640 ] 

ASF GitHub Bot commented on CB-10522:
-------------------------------------

GitHub user sarangan12 opened a pull request:

    https://github.com/apache/cordova-app-hello-world/pull/15

    CB-10522: Event binding in Hello World is misleading

    The current event binding in the Hello World example is slightly misleading. So, fixing it. 
    
    @nikhilkh @dblotsky @riknoll @rkatyal Can you please review and merge this PR?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sarangan12/cordova-app-hello-world CB-10522

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-app-hello-world/pull/15.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #15
    
----
commit a17a3d289a6e1428a34068040563d998faf63fc0
Author: Sarangan Rajamanickam <sa...@microsoft.com>
Date:   2016-02-05T19:25:34Z

    CB-10522: Event binding in Hello World is misleading
    
    Fixing the Hello World example

----


> Event binding in Hello World is misleading
> ------------------------------------------
>
>                 Key: CB-10522
>                 URL: https://issues.apache.org/jira/browse/CB-10522
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: App Hello World
>            Reporter: Richard B Knoll
>            Assignee: Sarangan Rajamanickam
>            Priority: Minor
>              Labels: triaged
>
> It is our recommendation that you bind to all of the Cordova events ({{pause}}, {{resume}}, etc.) in your {{deviceready}} callback so as to ensure that cordova.js and all your plugins are done being loaded. This is mentioned in the events guide [in the documentation|http://cordova.apache.org/docs/en/latest/cordova/events/events.pause.html]
> However, we include a {{bindEvents}} method in the template which implies that all event binding should happen there. We should probably just remove {{bindEvents}} altogether and add the event listener for {{deviceready}} in the {{initialize}} method since the other events we mention seem to be out of date. We should also add a comment explaining where Cordova related events should be bound to.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org